[HOLD for payment 2024-03-07] Bump eslint-config-expensify version in E/App

[roryabraham]

Following up on Expensify/eslint-config-expensify#85, let's bump the eslint-config-expensify version in E/App to 2.0.44+ and remove any redundant rules.

[roryabraham]

@blazejkustra is going to handle this, and it shouldn't require C+ review

[roryabraham]

self-assigning for tracking purposes

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

[blazejkustra]

PR is ready for C+ review

[jjcoffee]

Per this comment, I guess C+ review isn't required? cc @roryabraham

[jjcoffee]

@roryabraham Friendly bump on this question. 🙇

[roryabraham]

@jjcoffee to answer your question, yes I think C+ review is needed here. There are enough non-trivial changes that I think it's valuable in this case

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump eslint-config-expensify version in E/App #36849

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)

[jjcoffee]

I am due payment for the PR review on this. 🙇

[jjcoffee]

@roryabraham Would you mind adding the Bug label so a BZ gets assigned to issue payment? Thanks! 🙏

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[MitchExpensify]

Payment summary:

C: $250 @jjcoffee (Upwork)

[situchan]

No payment for me. I just pointed out regression in PR.

[MitchExpensify]

Fixed, thanks!

[MitchExpensify]

Offer here for you @jjcoffee https://www.upwork.com/jobs/~014f452ce3ae379cd2

[situchan]

Just for reference: the regression penalty won't be applied in these kinds of issues?

[MitchExpensify]

Where were the related regressions @situchan ?

[situchan]

Where were the related regressions @situchan ?

yes, #37465 (comment)

[jjcoffee]

@MitchExpensify Accepted, thanks!

[MitchExpensify]

Updated the payment summary to $250 because of the regression here #37465 (comment)

[MitchExpensify]

Paid and contract ended!