[HOLD for payment 2024-03-14] [Wave8] [Simplified Collect] Fetch collect workspace data when opening settings

[mountiny]

Part of wave8 cc @luacmartins @trjExpensify

Problem

At the moment, we load category or tags data for a policy either:

• on app start for your primary policy
• or when workspace chat, expense report or transaction thread are open in OpenReport

This leaves us with with case when user can navigate to settings of a workspace they are admin of after signing i without navigating to any open report that would load the categories or tags. Since opening the category workspace page for example at the moment does not call any API command, we do not load the categories and for the user it looks like as if the workspace had no categories

Solution

Possible solution:
Create OpenWorkspaceCategoryPage and OpenWorkspaceTagsPage commands (similarly for other policy pages), that will be READ API commands fetching the workspace categories or tags respectively. These API commands would take policyID as param

[melvin-bot]

Triggered auto assignment to @muttmuure (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[mountiny]

the solution still needs to be discussed

[luacmartins]

Thanks for creating this! Seems like the proposed solution is the way to go here. Is there any other ongoing discussion?

[mountiny]

Not in Slack, but I think it stemmed from this PR #36324 and testing

[trjExpensify]

What are the next steps here?

[luacmartins]

I'll work on the PRs to implement OpenWorkspaceCategoryPage and OpenWorkspaceTagsPage similar to what we're proposing for Tags. So I think ideally we get approvals on that Tag doc and the way we should implement this, so we don't end up with different ways of fetching these policy fields

[trjExpensify]

@luacmartins can we get going on this with tags out the door?

[luacmartins]

Yes, we got the PR to do this for tags merged yesterday. I'll get started on the other ones.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Call OpenPolicyCategoriesPage #37457

If no regressions arise, payment will be issued on 2024-03-14. 🎊

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[trjExpensify]

👋 Confirming we need to pay @s77rt for this PR review here do we?

[luacmartins]

Yes! Assigned them to the issue

[trjExpensify]

Offer sent!

[s77rt]

Accepted! Thanks!

[trjExpensify]

Paid!