[Awaiting payment 7th March] [$500] Hold Request - 'Reason' is not translated to Spanish

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Change app language preference to Spanish
2. Create an IOU with a user
3. Navigate to IOU reports details page
4. Click on three dot > Hold request

Expected Result:

'Reason' in the input field should be translated into Spanish

Actual Result:

'Reason' in the input field is not translated into Spanish

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385205_1708391701820.Screen_Recording_2024-02-20_at_3.16.25_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01470739ce07ee196a
• Upwork Job ID: 1759790323341258752
• Last Price Increase: 2024-02-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01470739ce07ee196a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Reason' in the input field is not translated into Spanish

What is the root cause of that problem?

We don't use translation here

What changes do you think we should make in order to solve the problem?

Use translation in

App/src/pages/iou/HoldReasonPage.tsx

Line 87 in 1806422

label="Reason"

label={translate('iou.reason')}

What alternative solutions did you explore? (Optional)

NA

[situchan]

@tienifr's proposal looks good. Straight forward fix.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @MonilBhavsar is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[MonilBhavsar]

We also have another similar translation issue here #36836
And given it's a minor issue. I am thinking to handle it internally

[tienifr]

And given it's a minor issue. I am thinking to handle it internally

@MonilBhavsar how do you think about halving the bounty and let contributors work on this? Since the issue is Help Wanted, contributors spent time and effort to make sure the cause is identified and the blocker is fixed quickly.

[trjExpensify]

I'm going to remove the Help wanted and External labels, as Monil has a PR up for this.

contributors spent time and effort to make sure the cause is identified and the blocker is fixed quickly.

I would probably agree if we aren't talking about a missing Spanish translation.

[BartoszGrajdek]

@MonilBhavsar already started working on a fix, so I'm not going to create a follow-up PR, let me know if I can help you with anything though! 👀

[trjExpensify]

Sounds good! Deployed to staging, so awaiting prod deploy and regression period to pay out @situchan for the review.

[melvin-bot]

@trjExpensify, @MonilBhavsar, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@trjExpensify, @MonilBhavsar, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

@situchan offer sent for the C+ review.

[trjExpensify]

Settled up!