[HOLD for payment 2024-03-15] [$500] Expense - App crashes when changing date, description, merchant of the request

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to workspace chat.
3. Create a manual request.
4. Go to request details page.
5. Tap Date.
6. Select a new date and save it.

Expected Result:

App does not crash.

Actual Result:

App crashes. This issue also occurs when changing description and merchant of the created request.

On web app, console error shows up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6385307_1708402578800.Screen_Recording_20240220_084451_New_Expensify__1_.mp4

Bug6385307_1708402696196!QA.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016c45b637c55448e3
• Upwork Job ID: 1759887389787447296
• Last Price Increase: 2024-02-20
• Automatic offers:
• Pujan92 | Contributor | 0

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016c45b637c55448e3

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[mountiny]

Waiting for proposals

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash on updating the request details

What is the root cause of that problem?

Seems the issue after this PR where we used modifiedCurrency for cachedTotal, modifiedCurrency won't be available when we aren't updating the currency. That leads to the error by passing an empty string to the convertToDisplayString function.

What changes do you think we should make in order to solve the problem?

We need to update it to consider currency as a fallback value when modifiedCurrency isn't available here.

App/src/libs/actions/IOU.ts

Line 1143 in 0f372c2

updatedMoneyRequestReport.cachedTotal = CurrencyUtils.convertToDisplayString(updatedMoneyRequestReport.total, updatedTransaction?.modifiedCurrency);

[paultsimura]

According to @cead22, it should be fixed by #36821

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Pujan92]

Thanks @paultsimura , just replied in slack

[mountiny]

@Pujan92 Can you raise a PR

I think we should do this:

We need to update it to consider currency as a fallback value when modifiedCurrency isn't available here.

The modifiedCurrency will only be defined if the user changed the currency, which is not always. We need to default to currency

[Pujan92]

Yes @mountiny

[mountiny]

Yeah I can handle the PR review on this one thank you @rushatgabhane

[mountiny]

@Pujan92 what is your ETA for the PR?

[Pujan92]

Raising a PR in 5 mins.

[Pujan92]

@mountiny PR is ready for review!

[mountiny]

Asking for a cp

[melvin-bot]

This issue has not been updated in over 15 days. @cead22, @johncschuster, @Pujan92, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[tylerkaraszewski]

This fix was CP'ed weeks ago, can this issue be closed?

[mountiny]

I think we need to pay @Pujan92 right?

[melvin-bot]

@cead22, @johncschuster, @Pujan92, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

Issuing payment now!

[johncschuster]

Payment has been issued via Upwork! Closing!