[HOLD for payment 2024-04-03] [LOW] [Splits] [$500] Chat - Error "a previously existing chat between these users." is missing when go online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #36538

Action Performed:

1. Log into New Dot on two devices, user A and user B
2. As user A, go offline and request money from user B
3. Verify an offline, optimistic request is created
4. As user B, go online and request money from user A
5. Verify the money request is successfully created
6. As user A, go back online

Expected Result:

When user A come back online error message about "a previously existing chat between these users." should appear

Actual Result:

"Hmm...It's not here" page appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385908_1708447855267.Recording__2341.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f6be5b10ed2e0055
• Upwork Job ID: 1759993160900755457
• Last Price Increase: 2024-02-20

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f6be5b10ed2e0055

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @blimpich (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[blimpich]

@arosiclair @thienlnam @aimane-chnaif can you look at this? Looks like this is related to #36538

[arosiclair]

Couldn't reproduce on v1.4.43-5:

There may be a difference using the "force offline" toggle. I am using dev tools.

[aimane-chnaif]

Screen.Recording.2024-02-20.at.9.17.18.PM.mov

Just tested on staging. Not able to reproduce other than weird unrelated bugs

[arosiclair]

Okay I was able to reproduce using the "Force offline" toggle. This seems to be caused by the extra navigation back to the report which triggers OpenReport for the optimistic report and gets it cleared from Onyx.

This is related but slightly different from the repro steps I fixed. Since this is still an edge case, I'll remove the blocker label and take care of this flow later.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[arosiclair]

Ran into a blocker but started a discussion in slack about it here

[arosiclair]

Alright per that discussion we'll make OpenReport set errorFields.notFound for reports that are inaccessible instead of deleting the report completely. errorFields.notFound will display the "it's not here" page only when there aren't any other helpful errors set.

I'll post a Web-E PR to get those changes out and then continue with the App PR.

[arosiclair]

Alright two PRs are updated and out for review. App PR's needs to go first:

• App PR
• Web-E PR

[arosiclair]

App PR deployed a week ago so this is due for payment @sonialiap

[sonialiap]

App PR deployed to prod Mar 27, 7 days makes payment due on Apr 3 (today 💸 )

[sonialiap]

@fedirjh $500 - offer sent

[fedirjh]

@sonialiap Thank you. Accepted!

[sonialiap]

Paid ✔️