[HOLD for payment 2024-03-18] [$500] [Simplified Collect][Profile] Invite flow

[luacmartins]

Implement the invite flow from the Simplified Collect: Profile, Members, Categories design doc

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01163b2b848dd14d88
• Upwork Job ID: 1760043376483004416
• Last Price Increase: 2024-02-20

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

@narefyev91 please comment here so I can assign you to this issue!

[narefyev91]

Hi! I'm Nicolay from Callstack - expert contributor group. I'll work on this issue so please assign me. Thank you.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01163b2b848dd14d88

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[dylanexpensify]

@narefyev91 mind giving an ETA on when you'll have a PR up?

[narefyev91]

@narefyev91 mind giving an ETA on when you'll have a PR up?

EOW but maybe earlier

[dylanexpensify]

Nice, how's progress?

[narefyev91]

Nice, how's progress?

Discussed some internal items with @luacmartins - but we should be on track! No major issues/blockers for now

[luacmartins]

@narefyev91 is still working on the draft PR

[melvin-bot]

@luacmartins @narefyev91 @rushatgabhane @dylanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[dylanexpensify]

@narefyev91 any updates here?

[narefyev91]

@dylanexpensify we were waiting for some BE changes - today PR will be open to review from C+ and design team

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.49-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Invite user to workspace via invite link #37525

If no regressions arise, payment will be issued on 2024-03-18. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Payment coming up!

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: N.A. This is a new feature.

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. Yes because new feature.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

   Preconditions:

   1. Has a workspace (new or existing one)
   2. Prepare join url link - use WorkspaceID and admin email for that workspace - ex. https://dev.new.expensify.com:8082/workspace/7DE6960B26D79E36/[email protected]

   For user:

   1. Open link in a new tab (for a new user / or user which already logged in)
   2. Verify that loading indicator is shown
   3. Verify that user redirects to all workspaces screen
   4. Verify that user sees a new line with workspace (in which join link was executed) and user sees chip with text "Requested"
   5. Verify that user could not interact with that workspace
   6. Wait until admin accept/decline request - verify that user will have/not have access to the workspace

   For Admin:

   1. When user used join link - verify that a new message is shown in admin room for that workspace
   2. Verify that 2 buttons are shown - "Accept"/"Decline"
   3. Click on any of them - verify that API request will be send, verify that message will be removed from admin room

[rushatgabhane]

@dylanexpensify could you please attach payment summary. Thanks 🙇

[JmillsExpensify]

Awaiting payment summary.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @narefyev91 is from an agency-contributor and not due payment
• Reviewer: @rushatgabhane owed $500 via NewDot

BugZero Checklist (@dylanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1760043376483004416/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[dylanexpensify]

Payment summary:

• Contributor: @narefyev91
• Contributor+: @rushatgabhane $500

Please apply/request!

[JmillsExpensify]

$500 approved for @rushatgabhane.