-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BZ checklist] [$500] [Held requests] IOS - Hold Request - Keyboard is up but the field is not focused with error message showing #36948
Comments
Job added to Upwork: https://www.upwork.com/jobs/~014db792b47c7bf65e |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @neil-marcellini ( |
We think that this bug might be related to #vip-bills |
ProposalPlease re-state the problem that we are trying to solve in this issue.IOS - Hold Request - Keyboard is up but the field is not focused with error message showing What is the root cause of that problem?We are not using What changes do you think we should make in order to solve the problem?We need to use
Resultios_focus_bug.mp4AlternativeInstead of using useEffect to focus input on mount we can use App/src/components/TextInput/BaseTextInput/index.tsx Lines 85 to 99 in e4c2ee2
<RNTextInput
ref={(element) => {
if (typeof ref === 'function') {
ref(element);
} else if (ref && 'current' in ref) {
// eslint-disable-next-line no-param-reassign
ref.current = element;
}
if (autoFocus) {
inputCallbackRef(element);
}
input.current = element as HTMLInputElement | null;
}} |
This is polish than bug. Not deploy blocker |
@situchan, visiting the form second time of afterwards shows error without any interactivity. |
I agree that it's not a blocker because this is a new feature that isn't on production yet, and it's a very minor issue. @situchan please start reviewing the proposals. |
Triggered auto assignment to @bfitzexpensify ( |
@Krishna2323's proposal looks good to me. |
Current assignee @neil-marcellini is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
@Krishna2323 in this issue, let's fix other similar pages with the same root cause. |
It's ideal to fix all occurrences but too many. It's definitely increased scope. |
@neil-marcellini bump incase you missed the question above ^ |
@neil-marcellini, friendly bump ^ |
In the interest of time, let's just move forward with just the reported pages for now 🙏 |
@situchan, PR ready for review. |
Automation didn't run. Needs payment on 3rd April. |
@trjExpensify, friendly bump for payments :) |
Offers sent! |
@trjExpensify accepted, thanks! |
Cool! Payment summary as follows:
|
Payment to @situchan done. @situchan, adding a manual BZ checklist here - please complete! Thanks BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@neil-marcellini, @bfitzexpensify, @Krishna2323, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Bump on the BZ checklist @situchan - thank you |
Bumping again @situchan - thank you! |
Ah, Situ is OOO. Will check back for when he's returned and bump this in Slack to be completed. |
@neil-marcellini, @bfitzexpensify, @Krishna2323, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@neil-marcellini, @bfitzexpensify, @Krishna2323, @situchan Eep! 4 days overdue now. Issues have feelings too... |
@neil-marcellini, @bfitzexpensify, @Krishna2323, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Still OOO, will bump when back. |
I'm going to close this one out myself. BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.43-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
The "Reason" field will be focused
Actual Result:
Keyboard is up but the field is not focused with error message showing up
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6385952_1708450041705.RPReplay_Final1708393963.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: