Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Public room - When the user leaves the room, another chat is displayed #37091

Closed
2 of 6 tasks
lanitochka17 opened this issue Feb 22, 2024 · 36 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.43-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/r/4098419659819887
  2. Verify the room chat is displayed
  3. Tap on sign in
  4. Login with an existing account
  5. Go to LHN
  6. Open any other chat, like a DM
  7. Go to the room chat
  8. Tap on the three dots menu and select "Leave"
  9. Verify Concierge chat is displayed
  10. Tap on the back arrow button
  11. Verify the last chat you opened is displayed

Expected Result:

The last chat you opened should not be displayed

Actual Result:

The last chat you opened is displayed after tapping on the back arrow button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6387438_1708548771330.Uqvd1974_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e2bc1f1429ae4674
  • Upwork Job ID: 1767609426339414016
  • Last Price Increase: 2024-04-02
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 22, 2024
Copy link

melvin-bot bot commented Feb 22, 2024

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@lanitochka17
Copy link
Author

@bz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@laurenreidexpensify laurenreidexpensify removed their assignment Feb 22, 2024
@laurenreidexpensify laurenreidexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 22, 2024
Copy link

melvin-bot bot commented Feb 22, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@laurenreidexpensify
Copy link
Contributor

I am OOO til from 23 Feb - 4 March and this got assigned after I logged off thanks

@dukenv0307
Copy link
Contributor

dukenv0307 commented Feb 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

  • Public room - When the user leaves the room, another chat is displayed

What is the root cause of that problem?

  • When leaving room, we have a logic to navigate user to the previous accessed report in here
  • But, we also have a logic that will navigate user to concierge report in here. In this one, Report.navigateToConciergeChat() is called.
  • The two above logics lead to the bug

What changes do you think we should make in order to solve the problem?

  • Solution 1 (Highly recommend): We also can remove the logic that navigate user to previous accessed report in here and let the logic handle it instead to make sure there is one logic that handles the navigation after leaving room and it works properly when user leaves room in other devices

  • Solution 2: Or, we can create a global variable, named isLeavingRoom. In here, set it to true. Then in here, updating it to:

            if(!isLeavingRoom) { Report.navigateToConciergeChat(); }

What alternative solutions did you explore? (Optional)

  • Because we already had a logic to navigate user to previous accessed report once we leave room, so we just need to make sure the Report.navigateToConciergeChat() in here is not called.

  • We can do it by updating this to:

            if(prevReport.chatType !== CONST.REPORT.CHAT_TYPE.POLICY_ROOM){
                Report.navigateToConciergeChat();
            }

@abekkala
Copy link
Contributor

@lanitochka17 your video doesn't seem to match the steps you provided.
Can you please provide a new video using the steps you mention?

Reopen if/when necessary

@dukenv0307
Copy link
Contributor

@abekkala I see that the video matches the steps that @lanitochka17 provided.

@lanitochka17 Can you double-check comment

@lanitochka17
Copy link
Author

@abekkala Hello
Full video step by step:

0-02-01-996f28f4104773f83412513e7f48a9be13c42adfd1f93ddc4ce1622855c4e981_c89b34c56dc9e9e.mp4

@lanitochka17 lanitochka17 reopened this Mar 6, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

@abekkala this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@abekkala
Copy link
Contributor

abekkala commented Mar 8, 2024

@lanitochka17 Can you check if the fix for this one should hav resolved this issue?

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@lanitochka17
Copy link
Author

Issue is still reproducible on the latest build 1.4.50-2

Cmzc9073.1.mp4

Copy link

melvin-bot bot commented Mar 11, 2024

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@abekkala abekkala added the External Added to denote the issue can be worked on by a contributor label Mar 12, 2024
@melvin-bot melvin-bot bot changed the title Public room - When the user leaves the room, another chat is displayed [$500] Public room - When the user leaves the room, another chat is displayed Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01e2bc1f1429ae4674

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@melvin-bot melvin-bot bot removed the Overdue label Mar 12, 2024
@alitoshmatov
Copy link
Contributor

alitoshmatov commented Mar 20, 2024

I am having a hard time reproducing it, I kinda did it at some point. But mainly after step 6 chat room provided in step 1 is not present in my LHN

@abekkala
Copy link
Contributor

@lanitochka17 can you reproduce?

@abekkala abekkala removed their assignment Mar 22, 2024
@abekkala abekkala added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 22, 2024
Copy link

melvin-bot bot commented Mar 22, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@abekkala
Copy link
Contributor

@CortneyOfstad I'm ooo until April 08 - I'll be taking back any issues still Open once I return


CURRENT STATUS:

We are still attempting to reproduce this and then receive proposals. It's also been assigned to the #wave-collect project. Curator will decide whether to keep open or close.

@abekkala abekkala self-assigned this Mar 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@CortneyOfstad
Copy link
Contributor

Not overdue – just waiting for someone to pick this up 👍

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
Copy link

melvin-bot bot commented Mar 26, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Mar 28, 2024
@CortneyOfstad
Copy link
Contributor

@lanitochka17 are you able to recreate this still on your side?

@melvin-bot melvin-bot bot removed the Overdue label Mar 28, 2024
@lanitochka17
Copy link
Author

@CortneyOfstad Issue is still reproducible

Cbjb9612.1.mp4

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@CortneyOfstad
Copy link
Contributor

@mvtglobally since you are having trouble recreating, I wanted to check in and see if you were experiencing any issues or confusion in regards to the steps above? If you think there is any room for improvement in the steps, please share them here so we can get them updated. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Apr 4, 2024
@CortneyOfstad
Copy link
Contributor

@lanitochka17 I am unable to recreate this on my side and @mvtglobally is unable to recreate this. Going to close — feel free to reopen if you can show consistent reproduction 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

7 participants