Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment 7th March] [Simplified Collect] [Members] Update member page translation and subtitle color #37096

Closed
luacmartins opened this issue Feb 22, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@luacmartins
Copy link
Contributor

Coming from this review, we need to update the new Member page subtitle color and translation.

cc @burczu

@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 22, 2024
@luacmartins luacmartins self-assigned this Feb 22, 2024
Copy link

melvin-bot bot commented Feb 22, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@luacmartins luacmartins changed the title Update member page translation and subtitle color [LOW] Update member page translation and subtitle color Feb 22, 2024
@luacmartins luacmartins moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 22, 2024
@burczu
Copy link
Contributor

burczu commented Feb 23, 2024

@lschurr @luacmartins Could you please assign me? It's a bug created by my recent change and I already have a PR prepared.

@luacmartins
Copy link
Contributor Author

Done!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 23, 2024
@burczu
Copy link
Contributor

burczu commented Feb 23, 2024

The PR is ready for review: #37123

luacmartins added a commit that referenced this issue Feb 23, 2024
…btitle-color

#37096 translation and subtitle color
@parasharrajat
Copy link
Member

I was C+ on the PR cc: @lschurr

@trjExpensify trjExpensify changed the title [LOW] Update member page translation and subtitle color [Simplified Collect] [Members] Update member page translation and subtitle color Mar 5, 2024
@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@trjExpensify trjExpensify added Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 and removed Weekly KSv2 labels Mar 5, 2024
@trjExpensify trjExpensify changed the title [Simplified Collect] [Members] Update member page translation and subtitle color [Awaiting Payment 7th March] [Simplified Collect] [Members] Update member page translation and subtitle color Mar 5, 2024
@trjExpensify
Copy link
Contributor

Updated the title and labels to reflect the payment hold, @lschurr. Coupla' days to go.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Mar 11, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

@burczu, @luacmartins, @parasharrajat, @lschurr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@parasharrajat
Copy link
Member

@lschurr This is ready to be finalized.

@lschurr
Copy link
Contributor

lschurr commented Mar 19, 2024

Payment summary:

  • Contributor: @burczu (agency - no payment needed)
  • Contributor+: @parasharrajat $500 (please request via newdot)

@lschurr
Copy link
Contributor

lschurr commented Mar 19, 2024

Sorry for the delay on this one! We're all set.

@lschurr lschurr closed this as completed Mar 19, 2024
@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 19, 2024
@parasharrajat
Copy link
Member

parasharrajat commented Mar 19, 2024

@lschurr I am C+ here. There might be some mistake with this post #37096 (comment). Can you please update it?

@lschurr
Copy link
Contributor

lschurr commented Mar 19, 2024

Ah, sorry about that @parasharrajat - GH autofilled incorrectly. I'm updating the payment summary - #37096 (comment)

@parasharrajat
Copy link
Member

Thanks.

@lschurr lschurr reopened this Mar 19, 2024
@parasharrajat
Copy link
Member

There is no need to reopen this issue. I will request it later.

@lschurr lschurr closed this as completed Mar 19, 2024
@parasharrajat
Copy link
Member

Payment requested as per #37096 (comment)

@JmillsExpensify
Copy link

$500 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

6 participants