[Remove Free Workspace Creation] Keep old NewDot clients from Creating Free Workspaces

[tgolen]

• Held on [$500] [Remove Free Workspace Creation] Update Welcome Message on NewDot #37152
• Held on [HOLD for payment 2024-04-09] [$500] [Remove Free Workspace Creation] Update Workspace Creation in NewDot to Create Collect Workspaces #37153

Coming from the design doc section here

It could be that old NewDot clients would still have old code allowing them to create free workspaces. To prevent that, there will be some logic added to the CreateWorkspace API command.

• Update api.php so that if the client passes a policy type of "free", then set the type to "team" here
• Add a Log::info() when that happens so we can detect when old clients are making bad requests

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dfd3c0fbfc17add5
• Upwork Job ID: 1761071438657032192
• Last Price Increase: 2024-02-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dfd3c0fbfc17add5

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[melvin-bot]

@mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Current assignee @mollfpr is eligible for the External assigner, not assigning anyone new.

[tgolen]

I am unassigning @mollfpr since they cannot review the internal PR on the API side.

[melvin-bot]

@tgolen Huh... This is 4 days overdue. Who can take care of this?

[tgolen]

Daily Update

• This issue is on HOLD
• The Web-E PR is created which is also on HOLD

Next Steps

• Wait for linked issues to be completed
• Take issue off HOLD and get PR merged

ETA

• Taken off HOLD by Friday Mar 8
• Merged and deployed by Wednesday Mar 13

[tgolen]

Daily Update

• This issue is still on HOLD
• The two dependent issues have been taken off HOLD today, so they are in motion

Next Steps

• Wait for linked issues to be completed
• Take issue off HOLD and get PR merged

ETA

Taken off HOLD by Monday Mar 11
Merged and deployed by Wednesday Mar 13

[tgolen]

Daily Update

• This issue is still on HOLD
• [$500] [Remove Free Workspace Creation] Update Welcome Message on NewDot #37152 has an accepted proposal but doesn't have a PR yet
• [HOLD for payment 2024-04-09] [$500] [Remove Free Workspace Creation] Update Workspace Creation in NewDot to Create Collect Workspaces #37153 is still evaluating proposals

Next Steps

No change

ETA

No change

[melvin-bot]

@tgolen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[tgolen]

Daily Update

• This issue is still on HOLD
• Update welcome note #38023 needs to be reviewed/merged/deployed
• Update Workspace Creation in NewDot to Create Collect Workspaces #38191 needs to be reviewed/merged/deployed

Next Steps

• Wait for those two PRs to be deployed

ETA

• Maybe ready to be taken off HOLD by March 20
• Have this issued finished and deployed by March 22
• I'll be OOO that week, so there could be some delay in getting it out, but the Web-E PR has already been reviewed and approved

[tgolen]

Daily Update

• This issue is still on HOLD
• Update welcome note #38023 is actively being reviewed
• Update Workspace Creation in NewDot to Create Collect Workspaces #38191 is actively being reviewed

Next Steps

• Waiting for those two PRs to be deployed to production

ETA

• No change

[tgolen]

Daily Update

• This issue is still on HOLD
• Update welcome note #38023 doesn't look like it has any changes since yesterday
• Update Workspace Creation in NewDot to Create Collect Workspaces #38191 doesn't look like it has any changes since yesterday

Next Steps

• Wait for those to PRs to be deployed to production
• @danielrvidal will be watching this while I am OOO next week to merge the Web-E PR once the two PRs above have been deployed to production

ETA (REVISED)

• Ready to be taken off HOLD by March 22
• Have this issue finished and deployed by March 26

[danielrvidal]

Sounds good, I'll check in on this on Monday!

[danielrvidal]

Daily Update

• This issue is still on HOLD
• Update welcome note #38023 doesn't look like it has any changes since yesterday
• Update Workspace Creation in NewDot to Create Collect Workspaces #38191 doesn't look like it has any changes since yesterday

Next Steps

• Wait for those to PRs to be deployed to production
  • I'm working with contributors on the first.
  • @MariaHCD is reviewing this tomorrow to unblock the second: https://github.com/Expensify/Web-Expensify/pull/41317
• I will be watching this while I am OOO next week to merge the Web-E PR once the two PRs above have been deployed to production

ETA (REVISED)

• Ready to be taken off HOLD by March 22
• Have this issue finished and deployed by March 26

[danielrvidal]

We ended up hitting a speed bump because we think we accidentally turned off the emails for NewDot, but I think we have a good path forward so will be creating next steps today.

[tgolen]

Daily Update

• Update Workspace Creation in NewDot to Create Collect Workspaces #38191 has been merged 🎉
• That only leaves one remaining PR until the hold can be removed: Update welcome note #38023

Next Steps

• Wait for final App PR to be merged
• Take the Web-E PR off HOLD and merge/deploy it

ETA

• Ready to be taken off HOLD by March 29
• Have this issue finished and deployed by April 3

[tgolen]

Daily Update

• Still on hold for Update welcome note #38023

Next Steps

• Same

ETA

• Same

[tgolen]

Daily Update

• Same

Next Step

• Same

ETA

• Same

[tgolen]

• Same

[tgolen]

• Same

[tgolen]

Daily Update

• This has been taken off HOLD because it really doesn't matter if the welcome note is up to date or not
• The Web-E PR has been merged

Next Steps

• Wait for it to be deployed and then this issue will close out

ETA

• It will probably deploy to production on Monday, April 8

[danielrvidal]

Woo! Thanks @tgolen

[melvin-bot]

@tgolen, @danielrvidal Whoops! This issue is 2 days overdue. Let's get this updated quick!

[tgolen]

Daily Update

• The Web-E PR has been deployed to production

Next Step

• Close this issue