[HOLD for payment 2024-03-07] [HOLD for payment 2024-03-06] [$500] Android - Chat - Unable to upload pdf file

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n

Issue reported by:

Action Performed:

1. Open the app and log in
2. Open any chat
3. Tap the "+" button > Add attachment > Choose document
4. Select a pdf file

Expected Result:

The preview of the PDF is displayed

Actual Result:

User is returned to the chat, the preview of the PDF is not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393398_1708986911406.video_2024-02-26_17-34-51.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @parasharrajat

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b98e23389e01c371

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb
@quinthar

[NikkiWines]

Confirmed that this isn't reproducible on iOS staging (1.4.44-0), will test on Android dev to see if it's reproducible there.

@davidcardoza do you know of any PRs related to PDFs that were recently merged/deployed?

[NikkiWines]

Hmm, I'm unable to reproduce on dev so far and don't have an android device to confirm that it's not reproducible on prod.

I don't see any changes to the AddAttachment logic that's still on staging and would be a culprit for this.

@kbecciv what account did you use to send the attachment, I'll check the logs to see if there's anything suspicious

[bernhardoj]

Looks like it's coming from #35164 where we are trying to get image size even though it's a PDF.

[parasharrajat]

@dukenv0307 Could you please confirm and look for the fix?

[kbecciv]

@NikkiWines Tester's account - [email protected]

[dukenv0307]

Checking this now.

[dukenv0307]

@DylanDylann The PR is ready for review.

[NikkiWines]

Oh yeah missed this since that PR was created back in January 😅 does indeed look like that's the likely culprit

[NikkiWines]

this is fixed now! 🎊 thanks @dukenv0307 @parasharrajat

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[DylanDylann]

@parasharrajat Thank you for helping review this PR, I am not available at that time

[garrettmknight]

Will pay out @parasharrajat for the review here. @dukenv0307 will get paid on the original issue.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix unable to add the file that is not image #37322

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: [$500] iOS - Profile - Photo upload options are missing #32307
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix logic get document from native #35164 (comment)
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@parasharrajat] Determine if we should create a regression test for this bug. No
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Open any report
2. Go to any chat.
3. Click on the plus icon > Add attachment > Choose document
4. Select a pdf file
5. The preview of the PDF is displayed

Do you agree 👍 or 👎 ?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $500 via NewDot

BugZero Checklist (@garrettmknight)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[garrettmknight]

@parasharrajat please request payment!

[parasharrajat]

@garrettmknight Please close this issue. I will request it later.

[parasharrajat]

Payment requested as per #37240 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat