[HOLD for payment 2024-03-29] [$500] [MEDIUM] Categories: "Parent" that does not have individual category is not grayed out

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: applause - Internal Team

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has Parent: Child category where the Parent does not have individual category.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go to + > Request money > Manual.
4. Enter amount > Next.
5. Click Show more > Category.

Expected Result:

The "Parent" that does not have individual category will appear grayed out.

Actual Result:

The "Parent" that does not have individual category is not grayed out.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393424_1708989041463.bandicam_2024-02-27_05-49-09-515.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014760c37372e21c4f
• Upwork Job ID: 1762259713696296960
• Last Price Increase: 2024-03-04

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014760c37372e21c4f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[cead22]

Since this is a minor aesthetic bug, I don't think it should be a blocker, and we can put this through the regular bug process

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Category - "Parent" that does not have individual category is not grayed out

What is the root cause of that problem?

We don't pass the disabled styles for the item here:

App/src/components/SelectionList/RadioListItem.tsx

Lines 43 to 49 in d561cf7

	textStyles={[
	styles.optionDisplayName,
	isFocused ? styles.sidebarLinkActiveText : styles.sidebarLinkText,
	styles.sidebarLinkTextBold,
	styles.pre,
	item.alternateText ? styles.mb1 : null,
	]}

What changes do you think we should make in order to solve the problem?

We should add styles.colorMuted to the text when the item is disabled.

textStyles={[
  ...
  
  isDisabled && styles.colorMuted,
]}

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Category - "Parent" that does not have individual category is not grayed out

What is the root cause of that problem?

• In here we do not have a text style in case the item is disabled

What changes do you think we should make in order to solve the problem?

• We should fix the text color issue in here by using gray text style (for example styles.colorMuted) if the option is disabled.

• Then, we need to fix the hover over color in here by updating it to hoverStyle={!isDisabled && styles.hoveredComponentBG}

• We can create a prop to just apply the above change in this case for backward-compatible

• We also need to consider the case: category A is the selected category in ND. Then disable it in OD. In this case, selected category A is displayed as the selectable item. And when we click on it, the selected category is gone. It seem to be a bug so I think we also need to fix it by allow user to deselect the selected item

What alternative solutions did you explore? (Optional)

• NA

Result

Screencast.from.27-02-2024.11.42.47.webm

[melvin-bot]

@cead22, @muttmuure, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[dukenv0307]

@shubham1206agra PR #38030 is ready to review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/37241: Parent option is not greyout #38030

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)
• @dukenv0307 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra / @dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra / @dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra / @dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra / @dukenv0307] Determine if we should create a regression test for this bug.
• [@shubham1206agra / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cead22]

On payment stage so not overdue

[muttmuure]

Handling

[muttmuure]

Original job failed and expired

[muttmuure]

https://www.upwork.com/jobs/~013b51541f9de74604

[muttmuure]

I've invited you both to a payment issue above

[muttmuure]

@shubham1206agra @dukenv0307

[dukenv0307]

I've invited you both to a payment issue above

@muttmuure I've submitted a proposal to the job, thank you!

[shubham1206agra]

@muttmuure Accepted the interview.

[muttmuure]

offers sent

[shubham1206agra]

@muttmuure Bump on the payment here.

[muttmuure]

Paying

[muttmuure]

Done