Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Welcome message received twice when joining the room and again when the role changed #37258

Closed
1 of 6 tasks
m-natarajan opened this issue Feb 27, 2024 · 49 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff

Comments

@m-natarajan
Copy link

m-natarajan commented Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kadiealexander
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708647751662189

Action Performed:

  1. Log in to OldDOt as user A
  2. Create a collect workspace
  3. Add user B as an employee
  4. Log in to NewDot as user A
  5. Create a room under the workspace created in step 2 and invite B
  6. Log in as user B and confirm there is a welcome message in the room invited by user A
  7. In OldDot update the user B role to Workspace admin from employee logging in as user A

Expected Result:

User B should not see a 2nd welcome message in the room

Actual Result:

There is a 2nd welcome message received for user B

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Screen Shot 2024-02-26 at 10 24 42 PM

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0169f2e49ea854c33a
  • Upwork Job ID: 1762319126210408448
  • Last Price Increase: 2024-03-19
@m-natarajan m-natarajan added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 27, 2024
@melvin-bot melvin-bot bot changed the title Welcome message received twice when joining the room and again when the role changed [$500] Welcome message received twice when joining the room and again when the role changed Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0169f2e49ea854c33a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@dylanexpensify
Copy link
Contributor

Nice - pending proposals!

@rayane-djouah
Copy link
Contributor

I think that this should be fixed from BE

@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
Copy link

melvin-bot bot commented Mar 4, 2024

@hoangzinh, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

@hoangzinh
Copy link
Contributor

Screenshot 2024-03-04 at 23 22 29

Agreed that it's a BE issue. It creates/returns another report action for the welcome message after we did the test step 7th

🎀👀🎀 C+ reviewed

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
Copy link

melvin-bot bot commented Mar 4, 2024

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link

melvin-bot bot commented Mar 5, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@dylanexpensify
Copy link
Contributor

Apologies, I've been OOO sick, but getting to this today! @srikarparsi can you confirm the proposal and BE need?

@srikarparsi
Copy link
Contributor

Hey @dylanexpensify! Yes, this does look like this needs a BE change. Do you think you could check if there's a wave/vip it fits into. I'm working on two wave issues currently so will probably not be able to pick this up but maybe a volunteer would be willing?

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@srikarparsi
Copy link
Contributor

Unassigning myself as I won't be able to work on this this week.

@melvin-bot melvin-bot bot removed the Overdue label Mar 11, 2024
@srikarparsi srikarparsi removed their assignment Mar 11, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Mar 12, 2024

@hoangzinh @dylanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@hoangzinh
Copy link
Contributor

@dylanexpensify should I "C+ review" again to assign another internal engineer to this issue?

@dylanexpensify
Copy link
Contributor

Yes please @hoangzinh!!

@dylanexpensify
Copy link
Contributor

Could not reproduce this time, @kadiealexander @hoangzinh can you confirm if you can?

@dylanexpensify
Copy link
Contributor

Not a huge priority yet

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 12, 2024
@dylanexpensify
Copy link
Contributor

Same as above, waiting for someone to take

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 15, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

@hoangzinh, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Apr 22, 2024

@hoangzinh, @dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Apr 24, 2024

@hoangzinh, @dylanexpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@dylanexpensify
Copy link
Contributor

@m-natarajan can you repro still?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 24, 2024
@dylanexpensify
Copy link
Contributor

Bump @m-natarajan

@melvin-bot melvin-bot bot removed the Overdue label Apr 29, 2024
@dylanexpensify
Copy link
Contributor

Bump @m-natarajan

@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
Copy link

melvin-bot bot commented May 7, 2024

@hoangzinh, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

@dylanexpensify
Copy link
Contributor

Bump @m-natarajan

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 7, 2024
Copy link

melvin-bot bot commented May 10, 2024

@hoangzinh, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@dylanexpensify
Copy link
Contributor

@lanitochka17 can you check for us here, please?

@melvin-bot melvin-bot bot removed the Overdue label May 14, 2024
@lanitochka17
Copy link

@dylanexpensify I am not able to reproduce this issue on the latest build 1.4.73-7

image

but if someone has a reproduction, I’ll write again

@melvin-bot melvin-bot bot added the Overdue label May 16, 2024
@lanitochka17
Copy link

lanitochka17 commented May 17, 2024

@dylanexpensify The second tester also could not reproduce the issue because No welcome message in the room.
(expensifail and gmail account)

bandicam.2024-05-17.15-43-07-524.mp4
bandicam.2024-05-17.15-46-19-023.mp4

Copy link

melvin-bot bot commented May 17, 2024

@hoangzinh, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented May 21, 2024

@hoangzinh, @dylanexpensify Still overdue 6 days?! Let's take care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

7 participants