-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-20] [$500] iOS - BA - Confirm button on double check pages is closer to the bottom than other pages #37339
Comments
Triggered auto assignment to @bfitzexpensify ( |
@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
This comment was marked as off-topic.
This comment was marked as off-topic.
ProposalPlease re-state the problem that we are trying to solve in this issue.The bank info confirmation button is too close at the button compared to other page. What is the root cause of that problem?The bank info page is wrapped with a screen wrapper that disables App/src/pages/ReimbursementAccount/BankInfo/BankInfo.tsx Lines 134 to 137 in 22cb01c
except for confirmation sub step because it just uses a plain scroll view. App/src/pages/ReimbursementAccount/BankInfo/substeps/Confirmation.tsx Lines 49 to 51 in 22cb01c
This also happens to other bank account confirmation sub step (personal info confirmation, business info confirmation, etc.). What changes do you think we should make in order to solve the problem?We should enable
<SafeAreaConsumer>
{({safeAreaPaddingBottomStyle}) => (
<ScrollView ... contentContainerStyle={[..., safeAreaPaddingBottomStyle]}>
includeSafeAreaPaddingBottom={SubStep === Confirmation}
includeSafeAreaPaddingBottom={screenIndex === manualSubsteps.length - 1}
const manualSubsteps = [{component: Manual}, {component: Confirmation, includeSafeAreaPaddingBottom: true}];
...
includeSafeAreaPaddingBottom={!!SubStep.includeSafeAreaPaddingBottom}
...
<SubStep.Component |
Job added to Upwork: https://www.upwork.com/jobs/~01a9093a007c21da81 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
Yes, definitely something we want to fix. @Ollyws, looks like we have a couple of proposals already ready for review |
ProposalProblem:The "Confirm" button at the bottom of the screen is not at the same height as other buttons for other sub steps Cause of the problem:The issue is that this confirmation page is missing the Solution:Add the |
📣 @scriptprojectsdev! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@bernhardoj's proposal LGTM. I think it's best we go with the |
Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
This sounds good to me too |
❌ There was an error making the offer to @Ollyws for the Reviewer role. The BZ member will need to manually hire the contributor. |
❌ There was an error making the offer to @bernhardoj for the Contributor role. The BZ member will need to manually hire the contributor. |
Weird those failed. You know anything about it @bfitzexpensify? Maybe ask in |
Yeah it happened across a few issues, Jack is working with Upwork |
PR is ready cc: @Ollyws |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-20. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@bfitzexpensify)
|
BugZero Checklist:
https://github.com/Expensify/App/pull/36763/files#r1533596226
N/A
Yes.
Regression Test Proposal
Do we agree 👍 or 👎 |
@Ollyws & @bernhardoj - in Upwork, I'm seeing that the offer for this job has been sent to both of you and is awaiting acceptance, but given this comment, I suspect that that might not be correct. Job name is [$500] iOS - BA - Confirm button on double check pages is closer to the bottom than other pages #37339 - do you both have an Upwork offer tied to that? |
I'm having the same problem as above. |
Gotcha. I've re-sent the offers, let me know if they're working or not. I might need to recreate the job fully if they aren't. |
It works, accepted |
Accepted, thanks. |
Cool, payments complete, regression steps proposed in https://github.com/Expensify/Expensify/issues/381507, closing this out - thanks everyone. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.44-4
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team
Issue found when executing PR: #37025
Action Performed:
Pre-requisite: the user must be logged in and have created a workspace.
Expected Result:
The Confirm button should be displayed on the same place as the other pages.
Actual Result:
The Confirm button is displayed closer to the button than the other pages.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: