-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Login - Infinite loading when login via Abracadabra page #37351
Comments
Job added to Upwork: https://www.upwork.com/jobs/~016551bee9d1747202 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @yuwenmemon ( |
I believe this was just due to the site slows we had just now. I'm not able to reproduce this anymore. |
Hello Recording.2451.mp4 |
Damn you're right. Very odd - looking into this now. |
Hmmm... I can't seem to reliably reproduce |
Okay, after some sleuthing looks like this is the PR that introduced the bug: #36852 |
I feel like the problem is that we're calling Kapture.2024-03-01.at.13.35.47.mp4 |
@JmillsExpensify, @yuwenmemon, @Ollyws, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Heads up I'll be OOO next week so if we need another engineer to merge anything for this feel free to ping in #expensify-open-source @Ollyws |
Onyx upgrade was deployed to production yesterday so this should be due for payment on the 29th. |
Can someone take care of payment for this one? Thanks! |
Payment summary:
Separately, @Ollyws what are your thoughts on regression tests? |
Offers sent out via Upwork. |
Contributor contract paid. |
@Ollyws Quick follow-up on this question when you get a chance. |
Regression Test Proposal
Do we agree 👍 or 👎 |
Requested payment in ND. |
Sounds good to me. I asked a colleague to confirm the payment summary before I approve payment. |
Payment summary: Contributor: @bernhardoj $500 paid via upwork |
$500 approved for @Ollyws |
This issue has not been updated in over 15 days. @JmillsExpensify, @yuwenmemon, @Ollyws, @bernhardoj eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@JmillsExpensify, @yuwenmemon, @Ollyws, @bernhardoj, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4343102
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
User should be logged in and there should be no long loading
Actual Result:
Infinite loading when login via Abracadabra page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6394640_1709066728559.Recording__2389.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: