Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Track Tax] Tax options do not come back after disabling and reenabling them #37416

Closed
6 tasks done
izarutskaya opened this issue Feb 28, 2024 · 13 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Found when validating PR : #36784

Version Number: v1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition:

  • User is an employee of Collect workspace.
  • The Collect workspace has some tax options.
  1. [Employee] Go to workspace chat.
  2. [Employee] Open request money page > Manual > Confirmation page.
  3. [Employee] Click Show more > Tax rate.
  4. [Admin] Disable all the tax options.
  5. [Admin] Enable all the tax options.

Expected Result:

The tax options will be showing for Employee when re-enabled.

Actual Result:

The tax options are not showing for Employee when re-enabled. The options only show up after relogin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6395222_1709111195109.bandicam_2024-02-28_03-27-32-787.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 28, 2024
Copy link

melvin-bot bot commented Feb 28, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@izarutskaya
Copy link
Author

@jliexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

@MonilBhavsar
Copy link
Contributor

Feature is WIP, so we can put this HOLD until we finish the implementation as it is being rolled out in phases https://github.com/Expensify/Expensify/issues/305057

@jliexpensify jliexpensify changed the title Tax - Tax options do not come back after disabling and reenabling them [HOLD] Tax - Tax options do not come back after disabling and reenabling them Feb 28, 2024
@jliexpensify
Copy link
Contributor

@MonilBhavsar do you want to be assigned this issue?

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

@jliexpensify Huh... This is 4 days overdue. Who can take care of this?

@MonilBhavsar MonilBhavsar self-assigned this Mar 5, 2024
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 5, 2024
@jliexpensify jliexpensify added Weekly KSv2 and removed Daily KSv2 labels Mar 8, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 8, 2024
@jliexpensify
Copy link
Contributor

@MonilBhavsar just moving to weekly so we're not pinged, feel free to change the priority.

@melvin-bot melvin-bot bot added the Overdue label Mar 18, 2024
@jliexpensify
Copy link
Contributor

Oh hold

@jliexpensify
Copy link
Contributor

@MonilBhavsar moved this to the Collect project as that deals with Taxes, right?

@trjExpensify trjExpensify changed the title [HOLD] Tax - Tax options do not come back after disabling and reenabling them [HOLD] [Track Tax] Tax options do not come back after disabling and reenabling them Apr 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 9, 2024
@jliexpensify
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Apr 10, 2024
@MonilBhavsar MonilBhavsar changed the title [HOLD] [Track Tax] Tax options do not come back after disabling and reenabling them [Track Tax] Tax options do not come back after disabling and reenabling them Apr 10, 2024
@MonilBhavsar
Copy link
Contributor

This is related to a pusher update. I'll work on the fix now

@MonilBhavsar MonilBhavsar added Daily KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause and removed Weekly KSv2 labels Apr 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 12, 2024
@MonilBhavsar MonilBhavsar added Weekly KSv2 and removed Daily KSv2 labels Apr 12, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2024
@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Apr 12, 2024

This is not a bug anymore. @izarutskaya you we please retest and confirm. Thank you!

Screen.Recording.2024-04-12.at.5.18.40.PM.mov

@MonilBhavsar
Copy link
Contributor

I'm closing this. Feel free to reopen if this happens and I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants