Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Tax - Tax amount does not change when the default tax rate changes #37418

Closed
6 tasks done
izarutskaya opened this issue Feb 28, 2024 · 11 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Feb 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Found when validating PR : #36784

Version Number: v1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition:

  • User is an employee of Collect workspace.
  • The Collect workspace has some tax options.
  1. [Employee] Go to workspace chat.
  2. [Employee] Open request money page > Manual.
  3. [Employee] Enter amount and proceed to confirmation page.
  4. [Employee] Click Show more.
  5. [Admin] On Old Dot, change the default workspace tax rate.

Expected Result:

The tax amount will change when the default tax rate changes.

Actual Result:

The tax amount does not change when the default tax rate changes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6395227_1709111726626.bandicam_2024-02-28_03-23-04-619.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 28, 2024
Copy link

melvin-bot bot commented Feb 28, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@izarutskaya
Copy link
Author

@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

@MonilBhavsar
Copy link
Contributor

Feature is WIP, so we can put this HOLD until we finish the implementation as it is being rolled out in phases https://github.com/Expensify/Expensify/issues/305057

@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
@bfitzexpensify bfitzexpensify changed the title Tax - Tax amount does not change when the default tax rate changes [HOLD] Tax - Tax amount does not change when the default tax rate changes Mar 4, 2024
@bfitzexpensify
Copy link
Contributor

Subscribed to the tracking issue.

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@bfitzexpensify
Copy link
Contributor

Still held

1 similar comment
@bfitzexpensify
Copy link
Contributor

Still held

@bfitzexpensify
Copy link
Contributor

Same update

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
Copy link

melvin-bot bot commented Mar 11, 2024

@bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@bfitzexpensify
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Mar 12, 2024
@MonilBhavsar
Copy link
Contributor

This is going to be fixed by https://github.com/Expensify/Expensify/issues/377575
So closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants