[$500] LHN-When no activity, WS can be marked as Unread but not announce, admin room.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.45
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team

Action Performed:

1. Launch app
2. Tap on icon on top left
3. Tap plus icon and create new workspace
4. Tap on chat icon below in footer
5. Tap fab --- start chat
6. Tap room
7. Enter all details and create a room with this new workspace
8. Navigate to LHN
9. Long press Workspace report( no activity) and mark as unread
10. Note it turns to bold
11. Long press admin/room/announce report ( no activity) and mark as unread
12. Note, the report is not shown in bold

Expected Result:

When no activity, WS can be marked as Unread similarly it should work for announce, admin and room.

Actual Result:

When no activity, Workspace report can be marked as Unread(shown in bold) but announce, admin and room report not shown in bold when user selects mark as unread.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6396629_1709184949775.no.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013632650058d49fc1
• Upwork Job ID: 1763659359403204608
• Last Price Increase: 2024-03-01

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

@joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #vip-vsb.

[joekaufmanexpensify]

Reproduced. I don't see why we wouldn't want to allow you to mark the announce or admins rooms as unread. Further, I can't mark user created rooms as unread on android web, which feels like a bug too.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013632650058d49fc1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[FitseTLT]

@joekaufmanexpensify Why would we need an empty room to be unread we intentionally made it to be always unread when it is an empty activity to fix #36013
If it is a must we need to revert that change

App/src/libs/SidebarUtils.ts

Lines 247 to 248 in 39a257d

	result.isUnread = ReportUtils.isUnread(report) && !!report.lastActorAccountID;
	result.isUnreadWithMention = ReportUtils.isUnreadWithMention(report);

and fix #36013 from BE so that the BE resets lastVisibleActionCreated when the last message is deleted from a room/report/chat that only has on message or report action.

[joekaufmanexpensify]

@FitseTLT Interesting. This is not saying that an empty room is always unread, it would be that you have the ability to mark it as unread if you intentionally want to. The change from that issue made it so an end user cannot intentionally mark an empty room as unread?

[FitseTLT]

What I meant was @joekaufmanexpensify We usually want mark as unread to check for some message or chat or room with chats And make it unread for empty chat didn't make sense to me. But if we decide it is a must the solution is reverting that change and fix that specific issue in the BE 👍

[joekaufmanexpensify]

Got it. We can do nothing for now then. I agree this isn't likely to come up much since it only impacts empty rooms.