[HOLD for payment 2024-04-09] [$500] [Held requests] show status on distance requests

[robertjchen]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Coming from the discussion here: #37121 (comment)

Update display of status on distance requests to show state (Approved/Pending/Canceled/Hold) like we do for Cash expenses.

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1710439388757009

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Create a distance request
4. Go to request details page
5. Click 3-dot menu > Hold request
6. Add a reason and save it

Expected Result:

Distance expense request should show Hold

Actual Result:

Distance expense request does not show any status

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e3e32c45e45f949f
• Upwork Job ID: 1769963579385311232
• Last Price Increase: 2024-03-19
• Automatic offers:
• situchan | Reviewer | 0
• ShridharGoel | Contributor | 0

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[rayane-djouah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold status is not displayed on distance and receipt requests previews.

What is the root cause of that problem?

Here:

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Lines 168 to 170 in 0bbfcd6

	} else if (isOnHold) {
	message += ` • ${translate('iou.hold')}`;
	}

we are appending the • Hold status only for cash requests.
and here:

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Lines 134 to 140 in 0bbfcd6

	if (isDistanceRequest) {
	return translate('common.distance');
	}
	if (isScanning) {
	return translate('common.receipt');
	}

we are not appending the • Hold status for distance and receipt requests.

What changes do you think we should make in order to solve the problem?

we need to add here this logic:

if (isDistanceRequest) {
    let message = translate('common.distance');
    if (isOnHold) {
        message += ` • ${translate('iou.hold')}`;
    }
    return message;
}

if (isScanning) {
    let message = translate('common.receipt');
    if (isOnHold) {
        message += ` • ${translate('iou.hold')}`;
    }
    return message;
}

only cash, receipt, and distance requests can be hold, we don't need to add this logic to split and card transactions.

[melvin-bot]

@robertjchen, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@robertjchen, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

[stephanieelliott]

Hey @robertjchen just want to check where we landed with this one from the original discussion in #37121 (comment) so we can figure out the Actual Result vs Intended Result

@robertjchen for now, • xxx is showing only after Cash (manual request)
i.e. not showing for distance requests. Is this expected (or at least out of scope)?

@situchan great catch! Let's pull this discussion to Slack to determine what's the best course of action. I think this change can go out in the interim however 👍

Was this ever pulled into Slack (I can't find anything)? Or was there general agreement that distance expenses should show the status (Hold, Approved, Pending, Canceled etc) on distance expenses?

[situchan]

oh it seems no discussion happened. Please assign me here.
I will raise discussion on slack.

[rayane-djouah]

Currently (in here) we only show the "Hold, Approved, Pending, Canceled" status and violations in cash requests previews.
for card transactions, we only shows "Pending" status.
for distance, receipt, and split requests, we are not including the status in the preview header text

[robertjchen]

thanks @situchan ! Feel free to link the thread here after you've created it, looking forward to see what others think

[stephanieelliott]

Hey @situchan have you started this convo? I'm not seeing it in Slack -- could you link it here?

[stephanieelliott]

@situchan has this convo been started? Is there anything we can do to move this issue along in the meantime?

[situchan]

started discussion - https://expensify.slack.com/archives/C01GTK53T8Q/p1710439388757009

[situchan]

We got answer. It should be consistent. Let's fix this to show status on all type of requests.

[stephanieelliott]

PR is undergoing QA now

[trjExpensify]

Hit staging 4 days ago. Should start the regression clock on the next deploy.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add status messages in money request previews #39048

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @ShridharGoel requires payment automatic offer (Contributor)
• @situchan requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertjchen] The PR that introduced the bug has been identified. Link to the PR:
• [@robertjchen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertjchen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ShridharGoel / @situchan] Determine if we should create a regression test for this bug.
• [@ShridharGoel / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[stephanieelliott]

This was a new feature and not a bug, so no regression test needed on this one.

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @ShridharGoel $500 via Upwork PAID
• Contributor+: @situchan $500 via Upwork PAID

Upwork job is here: https://www.upwork.com/jobs/~01e3e32c45e45f949f

[stephanieelliott]

Contributor: @ShridharGoel please accept the Upwork offer so we can issue payment

Bump on this @ShridharGoel

[ShridharGoel]

@stephanieelliott Accepted.

[robertjchen]

Has the payment been issued here? 🙏

[ShridharGoel]

Not yet, @stephanieelliott can you have a look?

[stephanieelliott]

All paid! See summary here: #37476 (comment)