[$250] [Report Fields] Title - Form fields in expense are updated when the formula changes, only when the page refreshes

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.45-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - internal Team
Slack conversation:

Issue found when executing PR #37160

Action Performed:

Preconditions: be a member of a collect policy, have no active expense report with this policy, and have the "report fields" beta turned on.

1. Login as a member in NewDot - > Request money from the workspace
2. Login as admin in OldDot -> Change the formula for an expense report (e.g. {report:type})
3. Check a previously created expense, and verify the fields are populated correctly with the optimistic data

Expected Result:

The expense report formula is updated automatically

Actual Result:

The expense report formula is updated only after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6397576_1709238771048.bandicam_2024-02-29_22-10-49-036.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0110c6cbcb96066337
• Upwork Job ID: 1772732351929339904
• Last Price Increase: 2024-04-30

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

I'm going to raise this internally because this behavior mirrors what happens on olddot right now. The formula for the report title when updated isn't reflected on existing reports until the report itself is updated in some way.

I'll update here shortly.

[strepanier03]

Raised here.

Perhaps @Expensify/design knows?

[strepanier03]

Held on #36170

[shawnborton]

Hmm I have no idea if we would expect report title formula changes made on OldDot to automatically push to NewDot without needing any kind of page refresh. Tapping my buddy @trjExpensify for a second opinion, otherwise I say we loop in engineering.

[trjExpensify]

Yeah, I think broadly where we can, we should make OldDot/NewDot changes update automatically cross-platform -- but there's for'sure a lot of places that's not happening.

Here, I'd only expect open reports to update though (I'd have said processing as well for instant, but looks like we're cutting report titles from that setup) -- else we get into the territory of updating the report titles of a bunch of historical reports that have already been approved, reimbursed, or closed losing whatever reference they had at the time of taking those actions.

As for whether this is should be working or not right now.. @thienlnam @paultsimura the issue was created when executing the testing steps of #37160, was it supposed to be added there or is this an adjacent consideration?

[paultsimura]

As for whether this is should be working or not right now.. @thienlnam @paultsimura the issue was created when executing the testing steps of #37160, was it supposed to be added there or is this an adjacent consideration?

#37160 was related solely to the optimistic data (which is built and displayed offline).
Changing the formula in OD won't affect the optimistic expense title, since the changes from OD will reach ND only after coming back online, and by that time, the optimistic title is already replaced with the data from the BE.

IMO, this is a separate issue, and most likely it's related to the ReportScreen memoization.

[thienlnam]

Hmm I have no idea if we would expect report title formula changes made on OldDot to automatically push to NewDot without needing any kind of page refresh. Tapping my buddy @trjExpensify for a second opinion, otherwise I say we loop in engineering.

This is known to not work right now, but should work in the future. We're currently working on a migration of some data storage in the BE in this issue

[trjExpensify]

Perfect!

[trjExpensify]

Added this to #wave-control as report fields will be available there ultimately.

[paultsimura]

@trjExpensify @thienlnam can you reproduce it at all?
For me, the App crashes (in Prod as well) when I change the formula in OD (reported here).

[thienlnam]

It's probably related to this issue as well - reportFields are behind beta so we should be okay

[strepanier03]

Assigned to a project and priority. Holding.

[JmillsExpensify]

Now that the PR for #36170 has hit staging, can we remove the hold from this issue?

[JmillsExpensify]

@youssef-lr What do you think about circling back on this one? I know you're still working on delegated splits, though this is one of two remaining polish issues for report fields.

[youssef-lr]

I think I can get to this next week.

[strepanier03]

I'm going to be out of the office all of next week, June 4-12th. If you need BZ action during that time please post in #bug-zero for a hand.

[youssef-lr]

No update yet, I'll try next week.

[youssef-lr]

I'll get started on this on Friday this week

[youssef-lr]

I haven't managed to get to this one due to working on stuff tied to deadlines or fast-apis

[strepanier03]

Thanks @youssef-lr.

[strepanier03]

Likely still not a priority, moving to monthly until it is.

[strepanier03]

I'm going to close this out for a few different reasons:

• The repro steps aren't possible to follow as we've locked Report Fields behind the Control paywall now.
• I cannot repro this any longer even for a Control workspace. The report fields are updating in real-time on the expense, including adding and removing fields.