[$500] Switch to focus mode modal appears every time sign out and sign in for same account

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709229575556299

Action Performed:

1. Have an account with many chats
2. Have your message Priority mode setting set tomost recent mode
3. Sign out and sign back in
4. See the "switch to focus mode" modal is shown and you are switched to focus mode
5. Switch your message Priority mode setting tomost recent mode
6. Sign out and sign back in

Expected Result:

The account's message Priority mode should not be switched to #focus mode, nor should the #focus mode modal appear since the account should not be in #focus mode.

Actual Result:

The switch to focus mode modal is shown and you are switched to focus mode

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2808.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f91501e19c2b41b5
• Upwork Job ID: 1765136631800881152
• Last Price Increase: 2024-03-05
• Automatic offers:
• ishpaul777 | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Switch to focus mode modal appears every time sign out and sign in for same account

What is the root cause of that problem?

• Calling API UpdateChatPriorityMode to set the focus mode will also set tryFocusMode: true (by BE `s response). But when singing out, we clear tryFocusMode key, that leads to the condition here return false, so the switch to focus mode modal appears.

What changes do you think we should make in order to solve the problem?

• We can keep the tryFocusMode when signing out. For example, add tryFocusMode key to this

What alternative solutions did you explore? (Optional)

• When user signs in, BE can return tryFocusMode

Update:

Currently, BE return nvp_tryFocusMode after sigining in. So we can use this key rather than tryFocusMode

Improvement:

• We are calling the tryFocusModeUpdate with 300ms delay:
  

  App/src/libs/actions/PriorityMode.ts

  Line 37 in 0c09803

  const autoSwitchToFocusMode = debounce(tryFocusModeUpdate, 300, {leading: true});

• This can lead to the case that focus mode is not set if the reports data is not fetched successfully when tryFocusModeUpdate is called. We can improve it as we did with onboard modal here. Below is the detail:

1. In here, create a useEffect that its dependences are whatever the tryFocusModeUpdate depends on. It will be something as:

    useEffect(() => {
        tryFocusModeUpdate(reports, hasTriedFocusMode, ...);
    }, [isLoadingApp]);

2. Then update the withOnyx in here to subscribe to the above data

3. Update the tryFocusModeUpdate to receive the reports, hasTriedFocusMode, ... as params

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[CortneyOfstad]

Hi @johncschuster! This issue was assigned to me after I went OoO last night, so reassigning. Thanks!

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Switch to focus mode modal appears and the priority mode is switched to focus every time a user signs out and signs in back.

What is the root cause of that problem?

In tryFocusModeUpdate, we check for hasTriedFocusMode value. If it's true, we won't switch it to focus mode. However, after sign-in, hasTriedFocusMode is null. We already guard the function to wait until all required data is available,

App/src/libs/actions/PriorityMode.ts

Lines 111 to 112 in af68510

	function tryFocusModeUpdate() {
	isReadyPromise.then(() => {

but we only check whether hasTriedFocusMode is undefined or not.

App/src/libs/actions/PriorityMode.ts

Lines 103 to 109 in af68510

	function checkRequiredData() {
	if (allReports === undefined || hasTriedFocusMode === undefined || isInFocusMode === undefined || isLoadingReportData) {
	return;
	}
	resolveIsReadyPromise();
	}

The hasTriedFocusMode value could be null because it's cleared when we sign out. That's why the type is either boolean, undefined, or null.

What changes do you think we should make in order to solve the problem?

In checkRequiredData, return early if hasTriedFocusMode is undefined or null.

Or even better, we can just check if hasTriedFocusMode is not a boolean.

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

I've clarified the repro steps and am adding the External label.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f91501e19c2b41b5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[ishpaul777]

@dukenv0307 @bernhardoj Thanks you for you proposal!

@dukenv0307 your primary solution might cause a regression when the next time user sign in with any other account. and alternative solution looks like a fix from backend is required but here i think solution from @bernhardoj works welll enough!

@bernhardoj root cause from your proposal makes sense and solution also test well!

@bernhardoj Proposal LGTM!
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[johncschuster]

@ishpaul777 just to clarify, are you suggesting above that I assign this one to @bernhardoj?

[ishpaul777]

ah yes! updated the comment to clarify

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @ishpaul777

[melvin-bot]

This issue has not been updated in over 15 days. @johncschuster, @techievivek, @bernhardoj, @ishpaul777 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[techievivek]

Closing this as per this comment #38115 (comment) since the issue is no longer reproducible.

[bernhardoj]

@techievivek @johncschuster Are we at least eligible for partial payment since we've done some work on the PR?

I think I ever seen some cases where the contributor is due to partial payment when they did their work on the PR but get closed because the issue is not reproducible anymore, but I could be wrong, so asking to be sure

[ishpaul777]

Yeah i feel there should be a compensation for the issue, For clarity, as per C+ docs why i think this is due for payment:

1. Proposals was reviewed by me and a proposal was selected and contributor was hired.
2. Contributor(@bernhardoj) worked on the PR and i tested and reviewed the changes and found BE related bug that was blocking the PR, then the original issue was no longer reproducable.

[techievivek]

Sorry, yeah, I do think we need to compensate here. I will reopen the issue so John can look into payment. Thanks.

[techievivek]

Going to DM John to take a look into the payments here.

[johncschuster]

Sorry I missed the GH notif! I'll get payment sorted today!

[ishpaul777]

@johncschuster gentle bump!

[johncschuster]

Sorry for the delay! I've issued payment through Upwork.