Distance - Hitting Enter in waypoint editor does not save the address

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.46-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Request money > Distance.
3. Click Start.
4. Enter the address and save it.
5. Click Start again.
6. Hit Enter.

Expected Result:

Hitting Enter will save the address and return to the distance request page,

Actual Result:

Hitting Enter only closes the address list and does not save the address.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6398246_1709298059189.bandicam_2024-03-01_20-58-27-324.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[kbecciv]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Hitting Enter in waypoint editor does not save the address

What is the root cause of that problem?

We don't pass disablePressOnEnter={false} to FormProvider inside IOURequestStepWaypoint that's why press on enter is disabled.

App/src/pages/iou/request/step/IOURequestStepWaypoint.tsx

Line 203 in a2d0cf2

submitButtonText={translate('common.save')}

What changes do you think we should make in order to solve the problem?

Pass disablePressOnEnter={false} to FormProvider inside IOURequestStepWaypoint. AddressSearch component is used in several places so will ensure we have correct behaviour at every place.

Result

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hitting Enter in waypoint editor does not save the address

What is the root cause of that problem?

If we don't have disablePressOnEnter prop passed in FormProvider, then by default it is set to true

App/src/components/Form/FormWrapper.tsx

Line 60 in 22cb01c

disablePressOnEnter = true,

What changes do you think we should make in order to solve the problem?

We need to set the default value to false in FormWrapper

Note: IMO, i think this approach would be better as i have recently seen a lot of bugs which complain on not able to save when hitting enter, so solving this in the main component sounds logical and will address future bugs as well :) This can save us a lot of time and money as well

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@kevinksullivan 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@kevinksullivan 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

@kevinksullivan this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[kevinksullivan]

Closing, since I am seeing this behavior for other addresses, like in the profile.

[Krishna2323]

@kevinksullivan, I think its not consistent with other inputs and the solution is not too complex.