Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2024-03-14] Swiping down the receipt image stucks at the bottom #37625

Closed
1 of 6 tasks
m-natarajan opened this issue Mar 1, 2024 · 16 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Mar 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @youssef-lr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709024399388799

Action Performed:

  1. Open any receipt image from the IOU details
  2. Swipe down from top to bottom

Expected Result:

The behavior should be similar to chat attachment image, should go back to the details page

Actual Result:

Swiping down on the receipt, the view just hangs and have to press back to get back to the report

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1709120295.mp4
RPReplay_Final1709316301.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bb59e55baa55ef61
  • Upwork Job ID: 1768025358979284992
  • Last Price Increase: 2024-03-13
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 1, 2024
Copy link

melvin-bot bot commented Mar 1, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kirillzyusko
Copy link
Contributor

I'm on it 👀 I implemented this feature so will prepare a fix for this problem 😎

Will open a PR soon 😊

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 1, 2024
@youssef-lr youssef-lr self-assigned this Mar 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 7, 2024
@melvin-bot melvin-bot bot changed the title Swiping down the receipt image stucks at the bottom [HOLD for payment 2024-03-14] Swiping down the receipt image stucks at the bottom Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-14. 🎊

Copy link

melvin-bot bot commented Mar 7, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
  • [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@youssef-lr] Determine if we should create a regression test for this bug.
  • [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@joekaufmanexpensify
Copy link
Contributor

Assigned @Pujan92 as he reviewed here

@joekaufmanexpensify
Copy link
Contributor

@Pujan92 can you complete BZ checklist so we can prep to issue payment?

@Pujan92
Copy link
Contributor

Pujan92 commented Mar 11, 2024

@joekaufmanexpensify I think this doesn't require a checklist as this is a follow-up issue for the new feature #37080.

@joekaufmanexpensify
Copy link
Contributor

Sounds good. We'll be all set to issue payment on Thursday then.

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bb59e55baa55ef61

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-03-14] Swiping down the receipt image stucks at the bottom [$500] [HOLD for payment 2024-03-14] Swiping down the receipt image stucks at the bottom Mar 13, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

Current assignee @Pujan92 is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 13, 2024
@joekaufmanexpensify joekaufmanexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 13, 2024
@joekaufmanexpensify
Copy link
Contributor

@Pujan92 offer sent for $500!

@Pujan92
Copy link
Contributor

Pujan92 commented Mar 14, 2024

Thanks @joekaufmanexpensify, Accepted!

@joekaufmanexpensify
Copy link
Contributor

@Pujan92 $500 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

All set, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants