[HOLD for payment 2024-04-03] [$500] Reimbursement - Save button loops between Rate and Track distance after refreshing Rate page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.46-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Workspace settings
3. Select a workspace
4. Go to Reimbursements > Rate
5. Click Rate to open rate input page
6. Refresh the page
7. Click Save
8. Click Save again

Expected Result:

RHP will close after clicking Save button

Actual Result:

App returns to rate input page after clicking Save button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6398727_1709323052061.bandicam_2024-03-01_21-12-58-365.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2728c1eb1d045e0
• Upwork Job ID: 1764689305475485696
• Last Price Increase: 2024-03-04

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave5
CC @dylanexpensify

[rayane-djouah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reimbursement - Save button loops the app between "Rate" and "Track distance" after refreshing "Rate" page.

What is the root cause of that problem?

here we are using the navigate function instead of goBack with a fallback. Consequently, the current page (WorkspaceRatePage) is not properly removed from the navigation stack. When attempting to click on save button to go back on the WorkspaceRateAndUnitPage, the page behind it in the stack remains the WorkspaceRatePage. This leads to an endless loop, as clicking save button keeps returning to the WorkspaceRatePage.

What changes do you think we should make in order to solve the problem?

In here, use goBack instead of navigate

        Navigation.goBack(ROUTES.WORKSPACE_RATE_AND_UNIT.getRoute(props.policy?.id ?? ''));

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reimbursement - Save button loops between Rate and Track distance after refreshing Rate page

What is the root cause of that problem?

Over here :

App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/RatePage.tsx

Line 49 in e870f17

Navigation.navigate(ROUTES.WORKSPACE_RATE_AND_UNIT.getRoute(props.policy?.id ?? ''));

we are having this - Navigation.navigate(ROUTES.WORKSPACE_RATE_AND_UNIT.getRoute(props.policy?.id ?? ''));

What changes do you think we should make in order to solve the problem?

Instead, we should do this - Navigation.goBack();

What alternative solutions did you explore? (Optional)

N/A

Result

Screen.Recording.2024-03-02.at.2.46.10.AM.mov

[apeyada]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reimbursement - Save button loops between Rate and Track distance after refreshing Rate page

What is the root cause of that problem?

App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/RatePage.tsx

Line 49 in e870f17

Navigation.navigate(ROUTES.WORKSPACE_RATE_AND_UNIT.getRoute(props.policy?.id ?? ''));

Here, we navigate to Track distance initial page

App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/InitialPage.tsx

Line 99 in 1bde30e

Navigation.goBack();

And here, we navigate back

What changes do you think we should make in order to solve the problem?

App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/InitialPage.tsx

Line 99 in 1bde30e

Navigation.goBack();

Instead of goBack, use
Navigation.navigate(ROUTES.WORKSPACE_REIMBURSE.getRoute(props.policy?.id ?? ''));

We can't use goBack on RatePage here because we should navigate to initial page on Save, instead of fully closing RHP

[ghost]

Hey @apeyada! I think it mostly depends on Reviewers what they want because if read the Expected Result carefully it states exactly this -RHP will close after clicking Save button. So it depends if they want to fully close the RHP or navigate back to the initial page after clicking on the Save Button.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2728c1eb1d045e0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[isabelastisser]

@dylanexpensify, is this related to wave5? Should this be internal or external?

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reimbursement - Save button loops between Rate and Track distance after refreshing Rate page

What is the root cause of that problem?

We are using goBack here instead of dismissModal

App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/InitialPage.tsx

Lines 99 to 100 in af0f6a3

	Navigation.goBack();
	};

What changes do you think we should make in order to solve the problem?

We should change it to dismissModal

        Navigation.dismissModal();

This is the proper navigation method (for modals) we use in every other places of the code base when navigating away from modals after saving as in here for e.g.

App/src/pages/tasks/TaskTitlePage.js

Lines 64 to 65 in af0f6a3

	Navigation.dismissModal(props.report.reportID);
	},

What alternative solutions did you explore? (Optional)

[aimane-chnaif]

Taking this over from @ntdiary's request

[melvin-bot]

❌ There was an error making the offer to @aimane-chnaif for the Contributor role. The BZ member will need to manually hire the contributor.

[isabelastisser]

@aimane-chnaif can you please review the proposal? Thanks!

[aimane-chnaif]

Proposals are in review. I will provide update tomorrow

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

❌ There was an error making the offer to @aimane-chnaif for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @rayane-djouah for the Contributor role. The BZ member will need to manually hire the contributor.

[rayane-djouah]

Thank you, will raise a PR tomorrow.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.56-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Save button loops between Rate/Unit and Track distance after refreshing Rate/Unit page #38323

If no regressions arise, payment will be issued on 2024-04-03. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment (Needs manual offer from BZ)
• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@bondydaa] The PR that introduced the bug has been identified. Link to the PR:
• [@bondydaa] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@bondydaa] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah / @aimane-chnaif] Determine if we should create a regression test for this bug.
• [@rayane-djouah / @aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

Payment summary:

Both contributors need manual offers in NewDot:

$500 @rayane-djouah requires payment C+ review - repayment in Upwork.
$500 @aimane-chnaif requires payment PR fix - requires payment in NewDot.

[isabelastisser]

@bondydaa, @aimane-chnaif can you complete the list above? Thanks!

[rayane-djouah]

@isabelastisser, Correction: I worked on the issue in the contributor role. And I need to be paid in Upwork. Thank you!

[rayane-djouah]

@isabelastisser Offer accepted, Thanks!

[isabelastisser]

Paid in Upwork.

[isabelastisser]

Payment summary:

$500 @aimane-chnaif requires payment PR fix - requires payment in NewDot. PENDING

[aimane-chnaif]

@isabelastisser I am still using upwork. Can you please reopen and sort payment? Thanks

[isabelastisser]

Thanks for the heads up, I sent you the offer in Upwork now.