Web - No limit message when add Message on Close account page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.46-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to Profile> Security> Close account
2. Add email address
3. In message field add very long text

Expected Result:

There should be message that added text is very long

Actual Result:

No message about text limitation for Message field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6398767_1709324738374.Recording__2442.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No limit message when add Message on Close account page

What is the root cause of that problem?

We are missing the maxLength prop here in CloseAccountPage:

App/src/pages/settings/Security/CloseAccountPage.tsx

Lines 100 to 108 in 0e72b4e

	<InputWrapper
	InputComponent={TextInput}
	inputID={INPUT_IDS.REASON_FOR_LEAVING}
	autoGrowHeight
	label={translate('closeAccountPage.enterMessageHere')}
	aria-label={translate('closeAccountPage.enterMessageHere')}
	role={CONST.ROLE.PRESENTATION}
	containerStyles={[styles.mt5, styles.autoGrowHeightMultilineInput]}
	/>

What changes do you think we should make in order to solve the problem?

Instead of showing error, we should have a character limit, like we do in other areas of the App.
We should add a maxLength prop to the TextInput here

We can set it to CONST.MAX_COMMENT_LENGTH as it used in other areas of the app:

maxLength={CONST.MAX_COMMENT_LENGTH}

Alternatively

• We can set the limit to CONST.DESCRIPTION_LIMIT or define a new const for an arbitrary value.

[rayane-djouah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No message limit when add Message on Close account page.

What is the root cause of that problem?

here we are not validating characters number limit.

What changes do you think we should make in order to solve the problem?

add this validation:

       if (values.reasonForLeaving.length > CONST.DESCRIPTION_LIMIT) {
           ErrorUtils.addErrorMessage(errors, 'reasonForLeaving', [
               'common.error.characterLimitExceedCounter',
               {length: values.reasonForLeaving.length, limit: CONST.DESCRIPTION_LIMIT},
           ]);
       }

we can use a different value than CONST.DESCRIPTION_LIMIT and add it to CONST file.
we should also and add a bottom margin to make the error looks good.

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@kevinksullivan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@kevinksullivan 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@kevinksullivan this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@kevinksullivan 12 days overdue. Walking. Toward. The. Light...

[kevinksullivan]

I don't think this is worth prioritizing.