Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Android - Chat - User suggestion list is not opening on entering @ in 2nd line. #37660

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 2, 2024 · 45 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.46
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch app
  2. Tap on a report
  3. Enter @ in compose box
  4. Select a contact from user suggestion list shown
  5. Tap enter
  6. Enter @ in compose box

Expected Result:

User suggestion list must be opened on entering @ in 2nd line

Actual Result:

User suggestion list is not opening on entering @ in 2nd line. It's slightly opening and closed again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6399593_1709396827882.nv.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c6808254765a233b
  • Upwork Job ID: 1769678891838267392
  • Last Price Increase: 2024-03-25
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 2, 2024
Copy link

melvin-bot bot commented Mar 2, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@trjExpensify
Copy link
Contributor

@lanitochka17 can we get the device and Android OS please?

I'm trying to reproduce this on a Pixel 6, Android 12 using Browserstack and can't seem to. Thanks!

@lanitochka17
Copy link
Author

@trjExpensify Hello
Redmi note 10s Android 13

@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2024
@trjExpensify trjExpensify added the Needs Reproduction Reproducible steps needed label Mar 7, 2024
@trjExpensify
Copy link
Contributor

Got it. Is it device specific? I don't have Redmi note 10s in Browserstack. I've tried in addition with Redmi 12 pro (Android 12) and Redmi 12 4G (Android 13), both of which I can't reproduce.

Can we have it re-tested and also use a couple of different Android devices please, thanks!

@melvin-bot melvin-bot bot removed the Overdue label Mar 7, 2024
@trjExpensify trjExpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Mar 7, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@trjExpensify
Copy link
Contributor

Awaiting the retest.

@melvin-bot melvin-bot bot removed the Overdue label Mar 11, 2024
@lanitochka17
Copy link
Author

Issue is still reproducible on the latest build 1.4.50-2
Realme6/Android11

Record_2024-03-11-17-13-41_4f9154176b47c00da84e32064abf1c48.mp4

Issue is still reproducible on the latest build 1.4.50-2
SG Note 10+/ A12

Screen_Recording_20240311_231829_New.Expensify.mp4

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2024
@trjExpensify
Copy link
Contributor

Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Mar 14, 2024
@trjExpensify trjExpensify removed Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause labels Mar 14, 2024
Copy link

melvin-bot bot commented Mar 16, 2024

@trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Mar 16, 2024
@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label Mar 18, 2024
@melvin-bot melvin-bot bot changed the title Android - Chat - User suggestion list is not opening on entering @ in 2nd line. [$500] Android - Chat - User suggestion list is not opening on entering @ in 2nd line. Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01c6808254765a233b

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 18, 2024
@trjExpensify
Copy link
Contributor

Doesn't look like anyone in the thread can reproduce it on the devices they've used. @shubham1206agra thinks it might be something to do with Live Markdown, but it's a bit TBD on why only certain devices are impacted.

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@jayeshmangwani
Copy link
Contributor

@trjExpensify Contributor has mentioned here that issue is reproducible on the slow devices, though I have tested on 2 device and both worked well both has Android version 13, so not sure whats the next step here, should we try to fix to fix this issue for the some devices ?

Copy link

melvin-bot bot commented Mar 25, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@trjExpensify
Copy link
Contributor

Do we have an idea of the root cause? As in, is it an issue on all devices under certain conditions?

@jayeshmangwani
Copy link
Contributor

@trjExpensify No, issue reproducible conditions are vague, as issue reproducible for some devices (not for the exact android version or particular mobile brands), and to be honest I haven't faced issue in any of the devices that I have tested recently

@DrLoopFall
Copy link
Contributor

Hi @cubuspl42, @Gonals, @bernhardoj
Since you've worked on same issue #26197 (User suggestion @ list not appearing on the second line)

Can you please check if this issue is also reproducible?


Here are the steps to reproduce the issue:

  1. by typing fast (500ms delay between newline and @)
Screenrecord
fasttype.mp4
  1. by using a slow device (can be emulated using an Android emulator on a system with high CPU usage/some background task running)
Screenrecord
slowmobile.mp4

@bernhardoj
Copy link
Contributor

I can reproduce it.

Screen.Recording.2024-03-28.at.11.38.42.mov

@jayeshmangwani
Copy link
Contributor

Thanks for the checking @bernhardoj
As you can reproduce this issue, it maybe helpfull if you can share the emulator details, so that I create the emulator with same configuration, then test and reproduce it reliably, i have tried quite few emulatoors but suggestion modal working fine for me, are you able to reproduce this issue everytime relaibly ?

@bernhardoj
Copy link
Contributor

I use Pixel 4a API 33, I never changed the settings, but here you go:

image image image

@jayeshmangwani
Copy link
Contributor

Thanks for the help @bernhardoj , finally I was able to reproduce this issue using this emulator.

@jayeshmangwani
Copy link
Contributor

@DrLoopFall's Proposal of passing the conditional leading and maxWait props and using lodashDefer to useCallback will solve this issue for the slow devices. Compared before and after applying the lodashDefer in Pixel 4a, it solves the current issue

🎀 👀 🎀 C+ reviewed

Copy link

melvin-bot bot commented Apr 1, 2024

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@trjExpensify
Copy link
Contributor

@madmax330 you good with this proposal?

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

@madmax330, @trjExpensify, @jayeshmangwani Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@trjExpensify
Copy link
Contributor

Oh, interesting. Can you guys still reproduce?

@madmax330 we're also awaiting the secondary proposal review here.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 12, 2024
@trjExpensify
Copy link
Contributor

Oh, interesting. Can you guys still reproduce?

Sorry, this was directed to @DrLoopFall & @jayeshmangwani! Let me know and we can close here if it's resolved.

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2024
@jayeshmangwani
Copy link
Contributor

@trjExpensify From the latest Play Store build, I was able to reproduce this issue only once after testing it for 10-15 minutes.

I am not able to reproduce this issue in the latest main branch; before, I was able to reproduce it easily from my local build, but now the problem is not happening to me.

@DrLoopFall
Copy link
Contributor

@trjExpensify, I'm also unable to reproduce this issue in the main branch.
I think we can close this now.

@trjExpensify
Copy link
Contributor

Okay, cool. Let's close it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

7 participants