[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Chat - Starting a chat with a specific number directs to the "Hmm" page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.47.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4381890
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap fab --- start chat
3. Enter and select +18183305298

Expected Result:

Starting chat with specific number must not direct to hmm page.

Actual Result:

Starting chat with specific number directs to hmm page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6402569_1709630846404.dm.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[marcochavezf]

I tried to reproduce it on production, and the expected behavior is to show the error inline:

For some reason we're not inserting the optimistic report in this case. Still investigating

[roryabraham]

Also, why are we getting a 666 back from OpenReport?

[marcochavezf]

Ah because we're not allowing certain carriers

[marcochavezf]

Hmm we're calling Onyx.set for the optimistic report two times and the second one is an empty object

[marcochavezf]

This is the offending PR. After testing the revert we're not calling OpenReport two times and we load the optimistic chat, but we don't show the error after refreshing though:

[marcochavezf]

Fixed here

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mvtglobally]

Retested on v1.4.47-7 And seeing the error now

[roryabraham]

closing this as completed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Point to the onyx hotfix branch #37804

If no regressions arise, payment will be issued on 2024-03-13. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Point to the onyx hotfix branch #37804

If no regressions arise, payment will be issued on 2024-03-14. 🎊