Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-22] [$500] [Simplified Collect][Taxes] Create WorkspaceTaxesPage #37787

Closed
luacmartins opened this issue Mar 5, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Mar 5, 2024

Implement this section of the Simplified Collect: Taxes doc

cc @kosmydel @filip-solecki

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019f235a497d678538
  • Upwork Job ID: 1765384542491787264
  • Last Price Increase: 2024-03-06
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 5, 2024
@luacmartins luacmartins self-assigned this Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

Current assignee @sakluger is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 5, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Mar 5, 2024
@luacmartins luacmartins moved this to Release 3: End to End Batch Processes & Accounting Export (US) in [#whatsnext] Wave 08 - Collect Plan Admins Mar 5, 2024
@Expensify Expensify deleted a comment from melvin-bot bot Mar 5, 2024
@luacmartins luacmartins moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@filip-solecki
Copy link
Contributor

Hi!
I am Filip from SWM and I would like to work on this issue!

@luacmartins
Copy link
Contributor Author

Assigned to the issue!

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Mar 6, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Taxes] Create WorkspaceTaxesPage [$500] [Simplified Collect][Taxes] Create WorkspaceTaxesPage Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019f235a497d678538

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 6, 2024
@luacmartins
Copy link
Contributor Author

@filip-solecki did you manage to get started on this issue?

@filip-solecki
Copy link
Contributor

@luacmartins Yes, it is almost done, I am preparing PR

@DylanDylann
Copy link
Contributor

@luacmartins Could you help to add me to Taxes doc ?

This is my email: [email protected]

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 8, 2024
@luacmartins
Copy link
Contributor Author

@DylanDylann done!

Copy link

melvin-bot bot commented Mar 13, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 13, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 15, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Simplified Collect][Taxes] Create WorkspaceTaxesPage [HOLD for payment 2024-03-22] [$500] [Simplified Collect][Taxes] Create WorkspaceTaxesPage Mar 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 15, 2024
Copy link

melvin-bot bot commented Mar 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@DylanDylann
Copy link
Contributor

@luacmartins @filip-solecki Currently, the checkbox on the tax list page is serving no purpose

Screen.Recording.2024-03-17.at.23.36.59.mov

I also don't see any information about this in the docs. It seems we missed it or have we had any plan for it?

@DylanDylann
Copy link
Contributor

@luacmartins @mountiny Could you grant me access to this doc? I want to have a deep understanding about tax feature to review related PRs

@kosmydel
Copy link
Contributor

@luacmartins @filip-solecki Currently, the checkbox on the tax list page is serving no purpose

Screen.Recording.2024-03-17.at.23.36.59.mov

I also don't see any information about this in the docs. It seems we missed it or have we had any plan for it?

It will be included in the bulk actions PR. We will add bulk enabling/disabling etc.

@mountiny mountiny self-assigned this Mar 18, 2024
@mountiny
Copy link
Contributor

Access granted

It will be included in the bulk actions PR. We will add bulk enabling/disabling etc.

Sounds good!

@sakluger
Copy link
Contributor

Sent an offer for $500 to @DylanDylann via Upwork: https://www.upwork.com/nx/wm/offer/101532660

@sakluger sakluger added Daily KSv2 and removed Weekly KSv2 labels Mar 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@sakluger
Copy link
Contributor

All paid out 👍

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 25, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Status: Release 3: End to End Batch Processes & Accounting Export (US)
Development

No branches or pull requests

6 participants