Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage #37788

Closed
luacmartins opened this issue Mar 5, 2024 · 28 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Mar 5, 2024

Implement this section of the Simplified Collect: Taxes doc

cc @kosmydel @filip-solecki

Issue OwnerCurrent Issue Owner: @anmurali
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Mar 5, 2024
@luacmartins luacmartins self-assigned this Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 5, 2024
@luacmartins luacmartins moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@luacmartins luacmartins changed the title [Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage [HOLD #37787][Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage Mar 5, 2024
@filip-solecki
Copy link
Contributor

Hi! I am Filip from SWM and I'd like to work on this issue!

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Mar 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

@anmurali, @luacmartins, @filip-solecki Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor Author

on hold

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2024
@DylanDylann
Copy link
Contributor

No longer on hold. I would be delighted if I could continue to accompany @filip-solecki on this issue

@DylanDylann
Copy link
Contributor

@luacmartins Also help to remove the hold label from the title of the issue

@filip-solecki It seems these features are our priority. Let's start making the PR for this one

@filip-solecki
Copy link
Contributor

I am preparing PR right now

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 15, 2024
@luacmartins luacmartins changed the title [HOLD #37787][Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage [Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage Mar 15, 2024
@mountiny mountiny self-assigned this Mar 18, 2024
@mountiny
Copy link
Contributor

PR is going to be merged today

Copy link

melvin-bot bot commented Mar 19, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@DylanDylann
Copy link
Contributor

@luacmartins @mountiny We handled 4 issues in this PR that make PR become bigger. I want to ask about how we process payments here

cc @anmurali

@luacmartins
Copy link
Contributor Author

Thanks for reaching out @DylanDylann! We'd still pay for a single PR review, since that's what was done here. While I understand that not all issues and PRs are made equal, and some are bigger or more complex than others, I still think that the compensation is fair in this situation.

@DylanDylann
Copy link
Contributor

@luacmartins Thank you for your response. I am happy with your decision. This is a similar case that we also should consolidate into an issue

cc @puneetlath

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Apr 2, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage [$500] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0147321941f3740121

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 2, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2024

I believe this is $500 to @DylanDylann and we can close it

@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 2, 2024
@luacmartins
Copy link
Contributor Author

Bump for payment

@luacmartins
Copy link
Contributor Author

Waiting on payment @anmurali

Copy link

melvin-bot bot commented Apr 8, 2024

@anmurali, @luacmartins, @mountiny, @DylanDylann, @filip-solecki Eep! 4 days overdue now. Issues have feelings too...

@anmurali
Copy link

anmurali commented Apr 9, 2024

Offer is here

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 9, 2024
@DylanDylann
Copy link
Contributor

@anmurali Accepted offer. Thanks

Copy link

melvin-bot bot commented Apr 12, 2024

@anmurali, @luacmartins, @mountiny, @DylanDylann, @filip-solecki Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor Author

Seems like we're all done here? @DylanDylann

@DylanDylann
Copy link
Contributor

@luacmartins I accepted the offer. Waiting for BZ pay the offer

@luacmartins
Copy link
Contributor Author

Thanks for the update. Just waiting on @anmurali

Copy link

melvin-bot bot commented Apr 16, 2024

@anmurali, @luacmartins, @mountiny, @DylanDylann, @filip-solecki Still overdue 6 days?! Let's take care of this!

@anmurali
Copy link

@DylanDylann has been paid.

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Apr 17, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

5 participants