Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-26] [HOLD #37788][Simplified Collect][Taxes] Create WorkspaceTaxesSettingsForeignCurrency #37791

Closed
luacmartins opened this issue Mar 5, 2024 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

Implement this section of the Simplified Collect: Taxes doc

cc @kosmydel @filip-solecki

@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Mar 5, 2024
@luacmartins luacmartins self-assigned this Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 5, 2024
@luacmartins luacmartins moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@luacmartins luacmartins changed the title [Simplified Collect][Taxes] Create WorkspaceTaxesSettingsForeignCurrency [HOLD #37788][Simplified Collect][Taxes] Create WorkspaceTaxesSettingsForeignCurrency Mar 5, 2024
@filip-solecki
Copy link
Contributor

Hi! I am Filip from SWM and I'd like to work on this issue!

@DylanDylann
Copy link
Contributor

The PR is merged

@DylanDylann
Copy link
Contributor

@luacmartins Am I assigned to this issue? Because I reviewed the PR

@luacmartins
Copy link
Contributor Author

Yes, just assigned you. Thanks for the ping!

@luacmartins
Copy link
Contributor Author

Hmm actually, I think we can close these issues and keep it all in #37788, since the same PR closed 4 issues.

@luacmartins
Copy link
Contributor Author

Closing this issue to keep it all in #37788

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 19, 2024
@melvin-bot melvin-bot bot changed the title [HOLD #37788][Simplified Collect][Taxes] Create WorkspaceTaxesSettingsForeignCurrency [HOLD for payment 2024-03-26] [HOLD #37788][Simplified Collect][Taxes] Create WorkspaceTaxesSettingsForeignCurrency Mar 19, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 19, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

4 participants