[HOLD for payment 2024-03-26] [Simplified Collect][Taxes] Create WorkspaceNewTaxPage

[luacmartins]

Implement this section of the Simplified Collect: Taxes doc

cc @kosmydel @filip-solecki

[melvin-bot]

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[kosmydel]

Hey, I'm from SWM and I will take care of that.

This issue will also cover adding two modals that are described in the design doc:

• AmountPicker,
• TextPicker.

[slafortune]

Thanks @kosmydel - I've assigned you 👍

[melvin-bot]

@slafortune, @luacmartins, @kosmydel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kosmydel]

This one is waiting for backend changes.

[luacmartins]

@kosmydel the API is in production now

[DylanDylann]

@luacmartins Since I have more context while reviewing this PR, Could I take over this issue?

[luacmartins]

All yours

[luacmartins]

No longer on hold. We also have a draft PR for this already

[kosmydel]

@kosmydel the API is in production now

We are waiting for backend changes, as there were problems with it.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[youssef-lr]

While yes it caused an issue, I don't think this should be treated as a regression, we had a prop there that was unused before.

Edit: the PR is from an agency, nvm!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Simplified Collect][Taxes] Creating new taxes #37967

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

• @kosmydel does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[slafortune]

@DylanDylann when you get a chance - Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

[DylanDylann]

@slafortune This is a new feature, we don't need the regression test

[slafortune]

@DylanDylann Yep! In fact, this automated message recognizes it is a new feature as well. We'll still want to create regression tests - it's a new feature we don't want to break, right? For more context - here

[luacmartins]

Yes, we'll add that as part of the design doc once the full feature is implemented though. No need to do it now.

[slafortune]

Got it! Offer sent here @DylanDylann

[slafortune]

Paid ✅