Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Error message appears when requesting IOU to a secondary login of a phone number #37835

Closed
1 of 6 tasks
m-natarajan opened this issue Mar 6, 2024 · 36 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Mar 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): secondary email([email protected]) of a SMS number account ([email protected]).
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709348197580109

Action Performed:

  1. Go to preexisting chat with secondary login email address [email protected] of SMS number [email protected]
  2. Request money

Expected Result:

Able to request money

Actual Result:

Error message appears:
unexpected error creating this chat, please try again later. There is a previously existing chat between thest users

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0189bc700718cf5a85
  • Upwork Job ID: 1766165401103810560
  • Last Price Increase: 2024-03-15
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@twisterdotcom
Copy link
Contributor

I can't recreate this:

37835.mp4

@mallenexpensify laid out some steps for Needs Reproduction issues in Slack: https://expensify.slack.com/archives/C01SKUP7QR0/p1709232158079079?thread_ts=1709232107.784279&cid=C01SKUP7QR0

  • GH created, $250 to start, bumped to $500 after 2 weeks
  • Assigned C+ reviewed discussions and steps
  • 3 contributors actively worked on finding the bug and steps
  • New issue created for $500, same C+ assigned.
  • The 3 contributors got first dibs for 48 hours to submit proposals before 'help wanted' was added.
  • Once PR is merged, ask C+ to propose the payments they recommend for contributors who helped find the repro steps.

Cool, so it sounds like we want the community to help identify the reproduction steps. Gonna wait until the outcome of this conversation so as not to share some things more widely than they need to be shared: https://expensify.slack.com/archives/C01SKUP7QR0/p1709920757503339

@twisterdotcom twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0189bc700718cf5a85

@melvin-bot melvin-bot bot changed the title Error message appears when requesting IOU to a secondary login of a phone number [$500] Error message appears when requesting IOU to a secondary login of a phone number Mar 8, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@twisterdotcom twisterdotcom changed the title [$500] Error message appears when requesting IOU to a secondary login of a phone number [$250] Error message appears when requesting IOU to a secondary login of a phone number Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

Upwork job price has been updated to $250

@twisterdotcom twisterdotcom changed the title [$250] Error message appears when requesting IOU to a secondary login of a phone number [$250] Error message appears when requesting IOU to a secondary login of a phone number - NEEDS REPRODUCTION STEPS Mar 8, 2024
@c3024
Copy link
Contributor

c3024 commented Mar 10, 2024

I could reproduce it by requesting money directly with the Request money from FAB instead of Start chat. It should be fixed from the backend.

Steps:

Pre-condition: User A has an existing chat with the primary login of User B

  1. [User A] Click on FAB > Request Money
  2. Input amount and click Next
  3. Input the secondary login of User B and select the result displayed below
  4. Click Request

Expected result: A money request from User A to User B created in the existing chat between User A and B

Actual result: A new chat is created between User A and secondary login of User B with an error from backend

TestSteps.mp4

@mallenexpensify
Copy link
Contributor

Thanks @twisterdotcom , I created this internal issue to track, reckon it'll be a few weeks til I prioritize

I think the first step, after BZ isn't able to reproduce, would be to add the Internal label to ask the C+ if they can and, if so, to provide additional details. Which, for this example, would have had @c3024 able to reproduce. Then you'd attempt again to confirm then the issue would move on. (and... sorry @c3024 , since you're C+ assigned, you wouldn't get compensation for being able to reproduce).

@melvin-bot melvin-bot bot added the Overdue label Mar 12, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

@twisterdotcom, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@twisterdotcom
Copy link
Contributor

Ah nice, well okay. Let me see if I can reproduce with that way too @c3024.

@melvin-bot melvin-bot bot removed the Overdue label Mar 14, 2024
Copy link

melvin-bot bot commented Mar 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Mar 18, 2024
@twisterdotcom
Copy link
Contributor

Yeah, this is odd, the bug is real!

  1. Open staging.new.expensify.com
  2. Use the green plus button to Request Money > $X > [email protected]
  3. Witness the error.

866608899df455ea-LHR

406 Chat report with these participants already exists with different ID

86660889ce3b55ea-LHR

404 Report not found

37835.mp4

As @c3024 says, likely internal.

@melvin-bot melvin-bot bot removed the Overdue label Mar 18, 2024
@twisterdotcom twisterdotcom removed the Needs Reproduction Reproducible steps needed label Mar 18, 2024
@twisterdotcom twisterdotcom changed the title [$250] Error message appears when requesting IOU to a secondary login of a phone number - NEEDS REPRODUCTION STEPS [$250] Error message appears when requesting IOU to a secondary login of a phone number Mar 18, 2024
@twisterdotcom twisterdotcom added Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Mar 18, 2024
@twisterdotcom
Copy link
Contributor

Waiting on an internal engineer

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@twisterdotcom
Copy link
Contributor

The bug still exists:
image

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@twisterdotcom
Copy link
Contributor

It still very much exists. @mvtglobally what flow are you testing? I get this every single time I request money/submit expense to [email protected] using the FAB.

@melvin-bot melvin-bot bot removed the Overdue label Apr 29, 2024
@mvtglobally
Copy link

What are we missing?

1714152746057.bandicam_2024-04-26_23-00-53-208.mp4
1714156931585.Screen_Recording_2024-04-26_at_21.39.02.mp4

@c3024
Copy link
Contributor

c3024 commented May 1, 2024

@mvtglobally In the second video, you should already have chat with David's sms before requesting money from their secondary login.

Flow in the first video does not reproduce this bug. You should start with submit expense from FAB as mentioned here

@mvtglobally
Copy link

@c3024

Can you pls comment with the exact steps from a Brand new account. Unfortunately, we need to use new accounts as messaging David's sms is not a viable option

@twisterdotcom
Copy link
Contributor

  1. Create a new account
  2. Create a DM chat with [email protected]
  3. Create a request (submit expense) to [email protected]

@mvtglobally
Copy link

@twisterdotcom Are you able to reproduce it with any other account rather than [email protected] or [email protected]

It is not reproducible if we use other SMS and email accounts

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@twisterdotcom
Copy link
Contributor

I literally just created an account for +447876868752 with a secondary login of [email protected] and recreated the bug straight away:

37835.mp4

The bug is real and definitely exists.

@melvin-bot melvin-bot bot removed the Overdue label May 14, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week)

1715962343820.bandicam_2024-05-17_21-41-04-448.mp4
1715967174957.Screen_Recording_2024-05-17_at_13.29.34.mp4

@melvin-bot melvin-bot bot added the Overdue label May 22, 2024
@twisterdotcom
Copy link
Contributor

@mvtglobally could you please test with the account I provided from above? So try creating an expense with [email protected]?

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2024
@mvtglobally
Copy link

looks like we are only able to reproduce if there is an existing chat with the primary login of a user

Recording.521.mp4

@c3024
Copy link
Contributor

c3024 commented May 30, 2024

Yes, that is what I mentioned as a pre-condition here.

Pre-condition: User A has an existing chat with the primary login of User B

@twisterdotcom
Copy link
Contributor

Great, do we think this is still Internal now then?

@c3024
Copy link
Contributor

c3024 commented May 30, 2024

Great, do we think this is still Internal now then?

I think so.

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Fifth week)

@twisterdotcom
Copy link
Contributor

Okay, finally I cannot reproduce. I have no idea how or when this was fixed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants