[HOLD for payment 2024-03-19] Tag - Not here page shows up when opening Tag from split details RHP

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has tags.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go to FAB > Split bill > Scan.
4. Create a split scan request.
5. Click on the split preview to open split details RHP.
6. Click Tag.

Expected Result:

Tag list opens without issue.

Actual Result:

Not here page shows up when opening Tag from split details RHP.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6405274_1709810064956.20240307_190957.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

[FitseTLT]

We have already figured out this before it was created and working on it. PR fixing the regression on review stage
@puneetlath

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[luacmartins]

@FitseTLT do you have a link to the PR?

[FitseTLT]

#37879 👍

[roryabraham]

again I suspect this is NAB because tags are a collect feature and thus need to be enabled with a JS snippet in OldDot, no?

[roryabraham]

anyways, looks like we may have a WIP fix?

[ishpaul777]

anyways, looks like we may have a WIP fix?

Yep its completed but I have asked @FitseTLT to retest and update videos, otherwise in my testing PR looks goods to CP 👍

[puneetlath]

again I suspect this is NAB because tags are a collect feature and thus need to be enabled with a JS snippet in OldDot, no?

I agree with this. Removing it as a deploy blocker.

[puneetlath]

PR was merged. It's a regression from another PR so no payment is needed here. Closing.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Fix - allow receipt split bill tag editing #37879

If no regressions arise, payment will be issued on 2024-03-19. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@puneetlath] The PR that introduced the bug has been identified. Link to the PR:
• [@puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@puneetlath] Determine if we should create a regression test for this bug.
• [@puneetlath] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: