-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [Performance] Limit getReportName to first 5 participants #37925
Comments
50 tasks
Job added to Upwork: https://www.upwork.com/jobs/~01bcaa1758a6b23688 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
Upwork job price has been updated to $250 |
This comment was marked as resolved.
This comment was marked as resolved.
@muttmuure I think we owe @mollfpr for review of #37907 before we can close this out. |
Okay @mollfpr, thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem:
In some cases, when the number of participants is big, we were needlessly calculating getDisplayNameForParticipant where in the end, we wouldn't be able to display it since the output is trimmed afterwards anyways.
Solution
The number of participants used to determine the Report name via getReportName is limited to first 5 participants other than current user.
This change allows to cap the performance impact of getReportName (which is used within getOrderedReportIDs)
from here: https://expensify.slack.com/archives/C05LX9D6E07/p1709831181822099
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: