Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 374470]Task - System message does not appear for user B when editing task until page refreshed #37994

Closed
2 of 6 tasks
lanitochka17 opened this issue Mar 8, 2024 · 12 comments

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.49-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the app and log in as the user A
  2. Log in as the user B in incognito or another device
  3. [user A] Open the chat with user B
  4. [user A] Assign a task to user B
  5. [user B] Open the assigned task
  6. [User A] Change the title, description, or assignee

Expected Result:

The system message is displayed for user B at the same time as for user A

Actual Result:

The system message is displayed for user B after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6407160_1709916254908.Recording__275.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

Copy link

melvin-bot bot commented Mar 8, 2024

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@luacmartins
Copy link
Contributor

@thienlnam is this related to #36768?

@roryabraham
Copy link
Contributor

This smells like a back-end issue to me

@luacmartins
Copy link
Contributor

Yea, I agree just wanna confirm since @thienlnam worked on that related App PR

@paultsimura
Copy link
Contributor

@thienlnam is this related to #36768?

This looks like a BE Pusher issue (not 100% sure though and can't verify ATM), there is quite a lot taskedited-related BE changes pending, @thienlnam should have a tracking issue for them🤔

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 8, 2024
@thienlnam
Copy link
Contributor

Yes, this looks related to the pusher update not getting sent for the new EditTask reportAction - in any case this is not a blocker

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
Copy link

melvin-bot bot commented Mar 11, 2024

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thienlnam thienlnam added Monthly KSv2 and removed Daily KSv2 labels Mar 12, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 12, 2024
@thienlnam thienlnam changed the title Task - System message does not appear for user B when editing task until page refreshed [HOLD 374470]Task - System message does not appear for user B when editing task until page refreshed Mar 12, 2024
@thienlnam thienlnam assigned thienlnam and unassigned luacmartins Mar 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 12, 2024
@thienlnam
Copy link
Contributor

Still on hold until we get back to addressing task items

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@thienlnam thienlnam removed their assignment May 29, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 29, 2024
@melvin-bot melvin-bot bot closed this as completed Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

@lanitochka17, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants