[HOLD for payment 2024-04-05] [$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.50-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710094172947319

Action Performed:

1. Have same front part of the email address in 2 different domain ([email protected] and [email protected])
2. Sign in as [email protected]
3. Go to any chat and mention [email protected]

Expected Result:

mentioned user shouldn't be highlighted in green

Actual Result:

mentioned user highlighted in green to incorrectly render as the logged in account

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c23b4f231f3691d1
• Upwork Job ID: 1767259879670747136
• Last Price Increase: 2024-03-11

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c23b4f231f3691d1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[garatkarr]

Could not reproduce this using two emails with the same "front part" of the email. My email addresses did not have a sub-domain name like the report does and I have no way to create an email with a sub-domain.

[jeremy-croff]

I am able to reproduce with creating an account in old expensify since it doesn't require email verification.
I created [email protected]
Anytime I tag @[email protected] it shows the shortened part followed by the remainder.

This is how we are saving it:

However it's a regression from: #36697 which was deployed to prod 5 days ago. Should we still propose @situchan?

The code is naively saying if the first part + current user email exists in contact list then it's a short text we need to expand.
But we should also compare if the second part the users' email does not equal the last part.

[jliexpensify]

If it's a regression, it should go to @tienifr and @allroundexperts

[jliexpensify]

@situchan let me know if @jeremy-croff is correct and I can get this assigned to them

[hayes102]

is this still open to proposals ? i think its a regression yes and i have a proposal, should i wait?

[melvin-bot]

📣 @hayes102! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[tienifr]

@jeremy-croff Yes, it's my regression, I just created the PR cc @allroundexperts

[melvin-bot]

❌ There was an error making the offer to @situchan for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @tienifr for the Contributor role. The BZ member will need to manually hire the contributor.

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jliexpensify]

I am OOO from the 21st to 31st of March, but I don't think this needs reassigning, as it's a regression and no payment is needed. Please let me know if I am incorrect though!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix mention with the same front name #38121

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @tienifr requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

As per my comment here, I don't think payment is needed but lmk if I am wrong!

@allroundexperts any need for a checklist?

[jliexpensify]

Bump @allroundexperts - any checklist needed here?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot
• ROLE: @tienifr paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@jliexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1767259879670747136/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jliexpensify]

This is a regression from another PR so no payment needed.