[HOLD for payment 2024-06-20] [$250] [Violations] Tags - Violation for unselected dependent tags displays tag name briefly then changes to "tag"

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.50-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause-Internal team
Workspace ID: 34D57014C907E72E
Transaction thread reportID: 2426939351372174
Transaction ID: 7718685459543892670

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has multilevel dependent tags.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create a manual request without tags.
4. Go to request details page immediately after the request is created.

Expected Result:

The violation for unselected tags will display "missing tagname".

Actual Result:

The violation for unselected tags displays "missing tagname" briefly, then changes to "missing tag".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6409992_1710179947631.bandicam_2024-03-12_01-53-35-255.mp4

Dependent - Multi Level tags NEW.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f0cc71bb900348ff
• Upwork Job ID: 1769788312802717696
• Last Price Increase: 2024-05-23

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@stitesExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[izarutskaya]

Production video

Recording.2249.mp4

[luacmartins]

Demoting to NAB since it involves violations and that feature is behind a beta

[melvin-bot]

@isabelastisser, @stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f0cc71bb900348ff

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[isabelastisser]

Waiting for proposals.

[isabelastisser]

Hey @hoangzinh, can you do the PR review for this issue before the end of this week? Thanks!

[hoangzinh]

sure @isabelastisser

[hoangzinh]

Hi @cead22 @luacmartins can anyone help to add my email [email protected] (employee account) and [email protected] (admin WS account) to use violation beta? Thanks

[cead22]

@hoangzinh added

[melvin-bot]

@cead22, @hoangzinh, @isabelastisser, @pac-guerreiro Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hoangzinh]

We're still working on the PR #40741 (comment)

[melvin-bot]

@cead22, @hoangzinh, @isabelastisser, @pac-guerreiro Eep! 4 days overdue now. Issues have feelings too...

[hoangzinh]

PR was merged yesterday. Waiting to be deployed to staging/prod.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Tags - Violation for unselected dependent tags displays tag name briefly then changes to "tag" #40741

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)
• @pac-guerreiro does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)
• Contributor: @pac-guerreiro is from an agency-contributor and not due payment

BugZero Checklist (@isabelastisser)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1769788312802717696/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[isabelastisser]

@hoangzinh, can you please complete the BZ list? Thanks!

ROLE: @hoangzinh paid $250 Contributor role
Contributor: @pac-guerreiro is from an agency-contributor and not due payment

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: Add violation logic for multi level tags #37461
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37461/files#r1648218896
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes

[hoangzinh]

Regression Test Proposal

Create a policy in old dot with multi-level dependent tags. You can use this tags file dependent_tags.csv

1. Sign in to New dot
2. Click on Submit expense in a workspace you just created
3. Select manual and enter any valid amount
4. Fill the required fields while leaving the tag fields empty and create the expense
5. Click on the preview of the expense you just created
6. The tag fields that you didn't fill should display an error message - missing {tagName}, where tagName is the name of the tag field
7. Wait a bit (1 minute or so) until the app is refreshed with updated data from the server
8. Verify that the same error messages are showing in Step 6
9. Then, update a tag field that is missing
10. Verify that other tag fields should display a new error message All tags required

Offline tests

Same as above, but don't need step 7

1. Sign in to New dot
2. Click on Submit expense in a workspace you just created
3. Select manual and enter any valid amount
4. Fill the required fields while leaving the tag fields empty and create the expense
5. Click on the preview of the expense you just created
6. The tag fields that you didn't fill should display an error message - missing {tagName}, where tagName is the name of the tag field
7. Verify that the same error messages are showing in Step 6
8. Then, update a tag field that is missing
9. Verify that other tag fields should display a new error message All tags required

Do we agree 👍 or 👎

[hoangzinh]

Accepted offer. Thanks @isabelastisser

[cead22]

That looks good to me. I had written a similar testing script, which I think is a bit more comprehensive, what do you think

• In old dot, in the workspace editor > tags tab, switch on the Use multiple levels of tags and the People must tag expenses toggles
• Click import from spreadsheet, uncheck “Are these independent tags?”, and upload the file in this issue comment
• On new dot, press big plus sign > submit expense
• Select Manual tab (from Manual | Scan | Distance)
• Enter $15 as the amount amount and press next
• Press the workspace from the pre-testing steps (press the row, not the split button in the row)
• Press the merchant row and enter a merchant
  • Confirm the Required label shows on the State, Region, and City rows
• Press the Submit $15 button
  • Confirm the report preview has a red circle
• Press the report preview
• If the report has more than 1 expense
  • Confirm the money request preview has a red circle and shows “Review Required”
• Press the money request preview
  • Verify you see Missing State, Missing Region, and Missing City violations
• Press the Region menu item, and select a region
  • Verify that the Missing Region violation disappears right away
  • Verify you see All tags required violations under State and City
• Select a State
  • Verify that the see All tags required violation disappears from under State
  • Verify you see All tags required violations under City
• Select a City
  • Verify that the see All tags required violations are gone
• De-select City
  • Verify that the All tags required violation appears under City
• 🛜Switch to new dot and go offline
• Repeat steps 1-16. The report preview, money request preview should be grayed out
• Go online, and confirm everything looks the same, except nothing is grayed out
• Submit a new expense on the same workspace, and select all the required fields so there are no violation on that expense
• Click on the link in the transaction thread header to go back to the expense report if you didn’t land there already
  • Verify the money request preview for the first expense says Review Required next to the a red circle

[isabelastisser]

All set! Thanks, team!