Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIGH: [Public] Thread messages are missing from public room #38159

Closed
1 of 6 tasks
m-natarajan opened this issue Mar 12, 2024 · 14 comments
Closed
1 of 6 tasks

HIGH: [Public] Thread messages are missing from public room #38159

m-natarajan opened this issue Mar 12, 2024 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented Mar 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduciton
Reproducible in production?: needs reproduciton
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): @quinthar https://staging.new.expensify.com/r/868417741568295 and https://staging.new.expensify.com/r/6776919265133947
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710204955795119

Action Performed:

  1. Open a public room in which there are already a bunch of threads

Expected Result:

User should be able to view all the thread messages

Actual Result:

Thread messages are disappaeared

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
image (8)
image (7)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fe380d1a88aa6cc2
  • Upwork Job ID: 1767615415137488896
  • Last Price Increase: 2024-03-12
@m-natarajan m-natarajan added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01fe380d1a88aa6cc2

Copy link

melvin-bot bot commented Mar 12, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

Copy link

melvin-bot bot commented Mar 12, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@quinthar quinthar changed the title Thread messages are missing from public room HIGIH: Thread messages are missing from public room Mar 12, 2024
@mountiny
Copy link
Contributor

Seems like David's OpenReport call is not even getting the childReportID property and other thread related properties for the report actions which should be added here https://github.com/Expensify/Auth/blob/bfd557749a4f372ad331f74defb7df026fe1037d/auth/lib/Report.cpp#L6984-L7031

@mountiny mountiny changed the title HIGIH: Thread messages are missing from public room HIGH: Thread messages are missing from public room Mar 12, 2024
@mountiny mountiny removed their assignment Mar 12, 2024
@mountiny mountiny added the Hot Pick Ready for an engineer to pick up and run with label Mar 12, 2024
@mountiny
Copy link
Contributor

My plate is quite full right now focusing on performance and Critical wave collect tasks so sending this to the pool if anyone has spare cycles to dig into it. Given the reproduction steps will be quite tough locally it might take some time.

@melvin-bot melvin-bot bot added the Overdue label Mar 15, 2024
@abdulrahuman5196
Copy link
Contributor

Still haven't picked up

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 18, 2024
@anmurali
Copy link

@quinthar do you want to do an open call for volunteers for this bug?

@melvin-bot melvin-bot bot removed the Overdue label Mar 21, 2024
@jasperhuangg jasperhuangg self-assigned this Mar 22, 2024
@jasperhuangg
Copy link
Contributor

Can look into this

@quinthar
Copy link
Contributor

Thanks @jasperhuangg !

@quinthar quinthar changed the title HIGH: Thread messages are missing from public room HIGH: [Reliability] Thread messages are missing from public room Mar 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@anmurali
Copy link

@jasperhuangg is working on this now.

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@quinthar quinthar changed the title HIGH: [Reliability] Thread messages are missing from public room HIGH: [Public] Thread messages are missing from public room Mar 26, 2024
@jasperhuangg
Copy link
Contributor

I'm going OOO for the rest of this week, so I'm looking to get started on this next week

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@anmurali
Copy link

anmurali commented Apr 2, 2024

@jasperhuangg I know you just got back today but can you add an update either here or in Slack so we can keep the issue up to date?

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2024
@quinthar
Copy link
Contributor

quinthar commented Apr 2, 2024

is this still happening for anyone? This is working fine for me. I'm going to just close this; reopen if it's happening to you.

@quinthar quinthar closed this as completed Apr 2, 2024
@github-project-automation github-project-automation bot moved this from HIGH to CRITICAL in [#whatsnext] #vip-vsb Apr 2, 2024
@jasperhuangg
Copy link
Contributor

Tried to reproduce it as well with the same room and I'm able to load all the threads. Feel free to reopen if we see it crop up again and provide the reportID of the parent report and the thread, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

6 participants