[HOLD for payment 2024-04-03] [Wave Collect] [Workflows] Unable to toggle Make or track payments

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when validating PR : #37629

Version Number: v1.4.51-3
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal team

Action Performed:

Precondition user should have paid policy setup and user is admin

1. Navigate to workspace > workflows,
2. Try to toggle on "Make or track payments" option

Expected Result:

The toggle should be on

Actual Result:

Unable to turn the toggle on and an error happens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6411986_1710315533206.Screen_Recording_20240313_103225_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0127410c870d3223d5
• Upwork Job ID: 1767875828667895808
• Last Price Increase: 2024-03-13

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@youssef-lr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[izarutskaya]

Production

bandicam.2024-03-13.15-59-06-096.mp4

[mountiny]

I can look into this

[mountiny]

Direct reimbursement is only available in USD, AUD, GBP, EUR and CAD. Currently this policy is set to a currency that is not eligible for direct reimbursement. Please change policy currency in order to enable Direct Reimbursement

[mountiny]

this is not a blocker, the policy used in this case has a currency set to one which is not supported for direct reimbursement

[mountiny]

I think here we need to add a better error handling in regards to newDot, there is couple errors that can be thrown and we should ensure they are presented to the user in useful manner https://github.com/Expensify/Web-Expensify/blob/1ccc1f6534e7eb6cc2a0a239af59e4d8ede826f7/lib/PolicyAPI.php#L3699 for example https://github.com/Expensify/Web-Expensify/blob/1ccc1f6534e7eb6cc2a0a239af59e4d8ede826f7/lib/PolicyAPI.php#L3658

cc @lakchote maybe you will be interested in taking this one one later in the week

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0127410c870d3223d5

[lakchote]

The issue's title do not really reflect the root problem here which is to display error messages to the user.

@Expensify/marketing, in the case of generic errors related to Simplified Collect Workflows, do these messages look good to you?

The delayed submission parameter could not be changed. Please try again or contact support.
The submission frequency could not be changed. Please try again or contact support.
The monthly frequency could not be changed. Please try again or contact support.
The approver could not be changed. Please try again or contact support.

[melvin-bot]

Triggered auto assignment to @jamesdeanexpensify (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[jamesdeanexpensify]

I removed the "monthly frequency" error message completely. Can we use the "submission frequency" error message below for that one, too?

Delayed submissions couldn't be updated. Please try again or ask Concierge for help.
Submission frequency couldn't be updated. Please try again or ask Concierge for help.
Approver couldn't be updated. Please try again or ask Concierge for help.

[trjExpensify]

Deployed to staging!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.56-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Wave Collect] [Workflows] Display meaningful message when currency is not available for Direct Reimbursement #38318

If no regressions arise, payment will be issued on 2024-04-03. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

@jjcoffee — any update on the checklist above? Thanks!

[CortneyOfstad]

@jjcoffee — also sent you a job offer via Uwork, please let me know once you accept — thanks!

[jjcoffee]

@CortneyOfstad Accepted, thanks!

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A - this adds new features for error handling
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Test 1

1. Go to Workspace -> Profile, select an unsupported currency for direct reimbursement (currently this is any non-USD currency)
2. Go to Workspace -> Workflows, toggle on Make or track payments
3. Click on Connect bank account
4. Verify that a confirmation modal appears
5. Cancel the modal
6. Click again on Connect bank account
7. Verify that the modal appears again
8. Click on Update to USD
9. Verify that the Connect bank account modal appears in RHP

Test 2

1. Enable Make or track payments and ensure the toggle turns on
2. Tap Connect bank account and go through the flow to set up a VBBA account
3. Disable Make or track payments, ensure the toggle turns off
4. Change the workspace default currency to a non-USD currency
5. Enable Make or track payments, ensure the toggle is on
6. Tap Connect bank account and Update to USD in the modal
7. Dismiss the bank account modal and verify that you can toggle Make or track payments off

Do we agree 👍 or 👎

[CortneyOfstad]

Payment completed and regression test created here!

[CortneyOfstad]

Payment Summary

@jjcoffee — paid $500 via Upwork 👍