[Ideal Nav] WS switcher - Delayed transition of breadcrumbs from Workspace / Chat to Expensify / Chat

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• There are at least two workspaces.
• One of the workspaces has other members,

1. Go to staging.new.expensify.com.
2. Open workspace switcher > Select a workspace.
3. Go to Profile > Workspaces.
4. Select a different workspace that has members.
5. Go to Members.
6. Click on the invited members > Message .

Expected Result:

The breadcrumbs (Expensify / Chat) will sync with the changes in LHN.

Actual Result:

LHN shows all the chats first, then followed by the change of breadcrumbs (Workspace / Chat) to Expensify / Chat. The transition is not smooth.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6412965_1710378599220.bandicam_2024-03-14_09-00-00-162.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@techievivek I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[techievivek]

Doesn't need to be a blocker but I am checking the diff to figure out which PR could have caused this regression.

[techievivek]

Also, I can see there is a slight delay but not sure if this is due to some recent PR.

[mountiny]

I think this is not really a blocker but something to look at maybe from the performance perspective

cc @WojtekBoman since you worked on the switcher

[trjExpensify]

Yeah, let's take a look at this for sure.

[alexpensify]

Cool, this one is associated with WAVE-Collect

[techievivek]

Gentle bump @WojtekBoman, can you please take a look into this issue? 🙏

[WojtekBoman]

Hello! I've investigated it and I know what might cause this issue :) Currently in the top bar we rely on policyID stored in the context. This value is updated in the NavigationRoot.tsx file in the handleStateChange method. setActiveWorkspaceID method is called within setTimeout with 0 ms delay due to performance optimization. I believe that for this specific case we can read policyID from the navigation state instead of context, thanks to that transition between workspaces should be smooth :) I'll prepare a draft PR with the fix for that

[alexpensify]

Thanks for the update, I've updated the GH accordingly.

[alexpensify]

Weekly Update: The PR is still under review

[alexpensify]

Weekly Update: It looks like the last PR was approved, and now we are waiting for automation. Is that correct @parasharrajat?

[parasharrajat]

Yes.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[alexpensify]

Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.

@trjExpensify - While I'm offline, I need help here completing the payment process after this one clears the 7-day period. That said, it looks like the PR created regression, so we need to address that asap. Thanks!

[parasharrajat]

PR is merged.

[melvin-bot]

@alexpensify, @trjExpensify, @parasharrajat, @techievivek, @WojtekBoman Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@alexpensify, @trjExpensify, @parasharrajat, @techievivek, @WojtekBoman 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[trjExpensify]

Dropping off and handing this back to Al.

[alexpensify]

Noted, I'm going through my BZ batch soon and was planning to grab this one back.

[alexpensify]

Ok, I need to start the payment process tomorrow. Looking at the PR, it was merged on May 22.

[alexpensify]

Alright, keeping the summary as is since this was a more complicated PR and was quickly addressed:

#38281 (comment)

@parasharrajat please submit the request in Chat.

[parasharrajat]

Payment requested as per #38281 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat per this summary.