[HOLD for payment 2024-03-26] IOU - BNP buttons are smaller and narrower

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to FAB > Request money.
3. Go to Manual.

Expected Result:

BNP buttons are not small and narrow.

Actual Result:

BNP buttons are small and narrow (compared to production).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[cristipaval]

I'm going to demote this one to an NAB since it's a visual thing that doesn't affect the functionality. Tagging @Expensify/design in the meantime.

[izarutskaya]

@cristipaval I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[izarutskaya]

Production

[cristipaval]

@cristipaval I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Thanks @izarutskaya, I tagged the design team for now. Let's start from there

[narefyev91]

just let me know which size those buttons should be - will add a fix for that

[melvin-bot]

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

[shawnborton]

@narefyev91 I think the buttons on this page should use our large style (52px), but we do have some breakpoints to use smaller buttons if the viewport height is super small on mobile.

[dubielzyk-expensify]

Yep, exactly what Shawn said :)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix numpad buttons size #38385

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cristipaval] The PR that introduced the bug has been identified. Link to the PR:
• [@cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[jliexpensify]

Hi @abekkala - I'm OOO from 21st to 31st March, so assigning a buddy.

I don't think any payment is needed, but if I'm wrong, could you help out? Thanks!

[abekkala]

@jliexpensify LOL well, I'm ooo March 22 - April 07
But, let me do a double check on this one and create a Payment Summary

[abekkala]

PAYMENT SUMMARY FOR MAR 26

• Fix: @narefyev91 - CallStack, no payment needed
• PR Review: @sobitneupane [$500, if no regressions] Payment made via NEWDOT

It should be decided if a regression test is needed

[abekkala]

@slafortune will be handling while I'm ooo

[cristipaval]

payment not due yet

[slafortune]

Fix: @narefyev91 - CallStack, no payment needed
PR Review: @sobitneupane [$500, if no regressions] Payment made via NEWDOT

[jliexpensify]

Thanks April and Stevie!

[JmillsExpensify]

$500 approved for @sobitneupane