[HOLD for payment 2024-03-25] [Wave Collect] [Tags] Tag - Tag row is not grayed out when created offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when validating PR : #38158

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is an admin of Collect workspace.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Tags.
4. Go offline.
5. Click Add tag.
6. Add a tag.

Expected Result:

Tag row is grayed out when created offline

Actual Result:

Tag row is not grayed out when created offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6413023_1710383772345.bandicam_2024-03-14_10-32-45-394.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@madmax330 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag row is not grayed out when created offline

What is the root cause of that problem?

We don't get the pendingAction of tag when get the tag list to display in WorkspaceTagsPage

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 72 in b7a230e

value: value.name,

What changes do you think we should make in order to solve the problem?

We should return an extra field pendingAction: value. pendingAction here.

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 72 in b7a230e

value: value.name,

What alternative solutions did you explore? (Optional)

NA

[ikevin127]

Offending PR #38158 - which is still within the regression period (deployed to staging 17h ago, see #38158 (comment)).

[ishpaul777]

This was not in scope for the PR #38158 (comment) but i think we can handle this as not a blocker

[allroundexperts]

@ikevin127 That is not the offending PR. We just added the form for creating the tag. The list was done as part of another PR. @luacmartins @mountiny I think we discussed the issues with the list itself during the PR review. I can take over these as part of the original issue and raise a PR today if that works.

[ishpaul777]

I will happily take as C+ 😃

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[mountiny]

I agree with the course of action @allroundexperts highlighted, I think we should handle that as part of the previous issue (scope) we can leave this issue open and link the Pr to this one because the context is cleaner

New tags or anything needs to follow the offline patterns so I think it is in scope of the original bounty

[luacmartins]

Yes, this should be addressed as part of the project. cc @waterim

[allroundexperts]

PR created @luacmartins @mountiny

#38332

[mallenexpensify]

I'm a lil confused and looking for help. I have this issue which came from the PR test steps for this issue

• Web - No error is displayed under the tag after executing the command in the consol #38410

Why would y'all be able to follow the steps to pass the tests but QA isn't?
I can't remember seeing another bug report like this.

[mountiny]

You can execute the stuff in console only in dev mode locally, no on actual staging/ production

[mountiny]

The first snippet there is in oldDot where you can do it

Onyx snippet cannot be run in staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: allow selection list to be greyed for tags #38332

If no regressions arise, payment will be issued on 2024-03-25. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts / @ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts / @ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts / @ishpaul777] Determine if we should create a regression test for this bug.
• [@allroundexperts / @ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

@allroundexperts when you get a chance, can you complete the checklist so I can make the payments on Monday?

[luacmartins]

No need to regression steps on this one as we'll add it as part of the design doc.

[slafortune]

@ishpaul777 invite sent here

[allroundexperts]

@slafortune It was decided by @luacmartins and @mountiny that the compensation for #38158 would cover this issue as well. As such, there isn't a payment required here. ref #38289 (comment)

[slafortune]

AH! Thanks for those details @allroundexperts, I missed that! We'll just leave this unit the 25th 👍

[ishpaul777]

I haven't accepted the offer yet feel free to withdraw @slafortune