[HOLD for payment 2024-04-03] [$250] [Wave Collect] [Ideal Nav] Workspaces - Status bar is white in workspace list when app is in light mode

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when validating PR : #37421

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• App is in light mode.

1. Launch New Expensify app.
2. Go to Profile.
3. Go to Workspaces.

Expected Result:

The status bar will appear black when app is in light mode.

Actual Result:

The status bar is white when app is in light mode.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6413464_1710418834485.Screen_Recording_20240314_201622_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c548479525f9eebb
• Upwork Job ID: 1768704311192559616
• Last Price Increase: 2024-03-15
• Automatic offers:
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

@abekkala I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The status bar text is white which makes it invisible in light mode.

What is the root cause of that problem?

We define the status bar style for the workspace list page as light content.

App/src/styles/theme/themes/light.ts

Lines 114 to 117 in 0a512c9

	[SCREENS.SETTINGS.WORKSPACES]: {
	backgroundColor: colors.productLight100,
	statusBarStyle: CONST.STATUS_BAR_STYLE.LIGHT_CONTENT,
	},

This value is used in CustomStatusBarAndBackground. Because it's set to light content, the status bar color becomes white.

What changes do you think we should make in order to solve the problem?

Change the status bar style to dark content.
CONST.STATUS_BAR_STYLE.DARK_CONTENT

we might need to check for other page too

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspaces - Status bar is white in workspace list when app is in light mode

What is the root cause of that problem?

Only in the Workspace Setting Page i.e. Here :

App/src/styles/theme/themes/light.ts

Lines 114 to 117 in 0a512c9

	[SCREENS.SETTINGS.WORKSPACES]: {
	backgroundColor: colors.productLight100,
	statusBarStyle: CONST.STATUS_BAR_STYLE.LIGHT_CONTENT,
	},

we are using CONST.STATUS_BAR_STYLE.LIGHT_CONTENT, because of which the status bar is showing white content on white background.

What changes do you think we should make in order to solve the problem?

Since, there is a white background and white content case, we need to change it to CONST.STATUS_BAR_STYLE.DARK_CONTENT.

NOTE : NO OTHER PAGE NEEDS TO UPDATE THIS STYLE

What alternative solutions did you explore? (Optional)

N/A

Result :

Screen.Recording.2024-03-15.at.8.45.49.AM.mov

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[abekkala]

I agree that we should have dark text at the top when in light mode and light text when in dark mode.
It seems we're keeping light text in both modes.

[shawnborton]

Yeah, that seems like a bug to me. Flagging @mountiny @luacmartins as I think this is related to the ideal-nav v2 changes.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c548479525f9eebb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[mountiny]

Seems like coming from the ideal nav, seems like a minor change so changing to $250

@parasharrajat can you please review the proposals

[melvin-bot]

Upwork job price has been updated to $250

[abhigurjeet]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Workspace Setting Page - Status bar is white in workspace list when app is in light mode

What is the root cause of that problem?

In Workspace Setting Page :

App/src/styles/theme/themes/light.ts

Lines 114 to 118 in d17b4df

	[SCREENS.SETTINGS.WORKSPACES]: {
	backgroundColor: colors.productLight100,
	statusBarStyle: CONST.STATUS_BAR_STYLE.LIGHT_CONTENT,
	},
	[SCREENS.SETTINGS.WALLET.ROOT]: {

CONST.STATUS_BAR_STYLE is set to LIGHT_CONTENT which is causing the status bar to show light content on white LIGHT theme.
Since the backgroundColor: colors.productLight100 is White and CONST.STATUS_BAR_STYLE is set to LIGHT_CONTENT, this makes the status bar appear white almost entirely.

What changes do you think we should make in order to solve the problem?

CONST.STATUS_BAR_STYLE should be set to DARK_CONTENT for light theme.

Current Behaviour:

WhatsApp.Video.2024-03-16.at.12.20.33.AM.mp4

After making the required Changes:

The Status bar will have STATUS_BAR_STYLE set to DARK_CONTENT and the status bar will appear correctly in the app.


@parasharrajat Please review my proposal.

[melvin-bot]

📣 @abhigurjeet! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[abhigurjeet]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~013b026a356f3bc13f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[ghost]

updated proposal with a note

[bernhardoj]

PR is ready

cc: @parasharrajat

[parasharrajat]

On it.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[abekkala]

@sakluger I'm ooo until April 08 - I'll be taking back any Open issues when I return

---

CURRENT STATUS

PR has been created. Once it's deployed to prod this title should update with payment date.

Payments would go to:

• FIx: @bernhardoj [$250] Offer link
• PR Review: @parasharrajat [$250] - payment is via NEWDOT

[sakluger]

PR is on staging, I'll add the payment date once it's on prod.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.56-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix workspace list page status bar style #38574

If no regressions arise, payment will be issued on 2024-04-03. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger / @abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Theme switching: Dynamic StatusBar and scroll bars #32063
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/32063/files#r1540623406
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Android/iOS/mWeb

1. Switch to light mode
2. Open Settings > Workspaces
3. Verify the status bar text is black/dark

Do you agree 👍 or 👎 ?

[mountiny]

I dont think we will need regression test for this one, people would notice this quickly imho

$250 to @parasharrajat and $250 to @bernhardoj

[sakluger]

Summarizing payment on this issue:

Contributor: @bernhardoj $250, paid via Upwork
Contributor+: @parasharrajat $250, please request on Newdot

[parasharrajat]

Payment requested as per #38304 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat