Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-03-15 #38382

Closed
35 tasks done
github-actions bot opened this issue Mar 15, 2024 · 18 comments
Closed
35 tasks done

Deploy Checklist: New Expensify 2024-03-15 #38382

github-actions bot opened this issue Mar 15, 2024 · 18 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2024

Release Version: 1.4.53-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mountiny mountiny added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 15, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.53-1 🚀

@luacmartins luacmartins added the Daily KSv2 label Mar 15, 2024
@luacmartins luacmartins self-assigned this Mar 15, 2024
@luacmartins
Copy link
Contributor

Checking off #38328 and #38362. They were blockers in the previous checklist and got fixed, but we never removed the label

@luacmartins
Copy link
Contributor

Checking off #38402. Demoted to NAB

@luacmartins
Copy link
Contributor

Checking off #38404. Demoted to NAB.

@luacmartins
Copy link
Contributor

Checking off #38401. Fixed in staging.

@blimpich
Copy link
Contributor

#38325 doesn't work. 2nd commit that is responding to feedback breaks the functionality of the fix. Proof here. Revert here. Not going to cherry pick since this doesn't effect users, just us.

Checking off.

@kbecciv
Copy link

kbecciv commented Mar 15, 2024

TR is currently at 30% completion.

#36961 is pending verification
#38215 is pending verification in IOS
#38218 is pending verification
#38258 is pending verification in IOS
#38274 is pending verification
#38276 is pending verification in IOS
#38285 is pending verification
#38327 is pending verification
#38332 is failing with #38410, repro in prod - checking off

@luacmartins
Copy link
Contributor

Checking off #38425. Demoted to NAB

@luacmartins
Copy link
Contributor

Regression still has 60% to go so we won't deploy today. All blockers are clear as of now.

@kbecciv
Copy link

kbecciv commented Mar 16, 2024

TR is currently at 50% completion.

#38332 is failing with #38410, repro in prod - checking off

@kbecciv
Copy link

kbecciv commented Mar 17, 2024

TR is currently at 75% completion.

#38332 is failing with #38410, repro in prod - checking off

Deploy blocker:
#38450

@melvin-bot melvin-bot bot added the Overdue label Mar 18, 2024
@mountiny
Copy link
Contributor

Demoted #38450 fix should be in main

@mountiny
Copy link
Contributor

#38458 is internal blocker

@mountiny
Copy link
Contributor

Demoted #38459

Waiting for regression to be completed

@kbecciv
Copy link

kbecciv commented Mar 18, 2024

TR is 5% left!
#38332 is failing with #38410, repro in prod - checking off

@mountiny
Copy link
Contributor

Demoted #38465 no active blockers, regression not complete yet

@kbecciv
Copy link

kbecciv commented Mar 18, 2024

TR is completed!

#38332 is failing with #38410, repro in prod - checking off

No Deploy Blockers

@AndrewGable
Copy link
Contributor

:shipit:

@melvin-bot melvin-bot bot removed the Overdue label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants