[HOLD for payment 2024-03-29] [$250] [Wave Collect] [Workflows] Clean up the isAutoApprovalEnabled flag

[mountiny]

Problem

We use the isAutoApprovalEnabled flag to decide if the approval toggle should be on or off in Workflows page

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 137 in f84219f

isActive: policy?.isAutoApprovalEnabled ?? false,

We should however use a comparison to the policy.approvalMode as we do here to define if the auto approval is enabled. It is true when the approval mode is set to basic.

The isAutoApprovalEnabled property is not passed from the backend, it should be removed for now.

This property exists, but its used in different way and we can bring it to the app later.

Solution

Use the approvalMode property to determine the toggle state

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01573ee41af24d66fa
• Upwork Job ID: 1769144226309750784
• Last Price Increase: 2024-03-19

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01573ee41af24d66fa

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @hoangzinh (Internal)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clean up the isAutoApprovalEnabled flag

What is the root cause of that problem?

We use the isAutoApprovalEnabled flag to decide if the approval toggle should be on or off in the Workflows page

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 137 in f84219f

isActive: policy?.isAutoApprovalEnabled ?? false,

however this flag is not needed anymore since its value is not coming from the backend. We should however use a comparison to the policy.approvalMode as we do here to define if the auto approval is enabled.

What changes do you think we should make in order to solve the problem?

1. we need to remove this line, this, and this
2. change the isAutoApprovalEnabled to approvalMode here, here, and here
3. in WorkspaceWorkflowsPage change the pending action to policy?.pendingFields?.approvalMode instead. and change the isActive condition to:

isActive: policy?.approvalMode === CONST.POLICY.APPROVAL_MODE.BASIC,

POC

Screen.Recording.2024-03-17.at.2.35.11.AM.mov

[trjExpensify]

@mountiny confirming we're not looking for volunteers here and we're done?

[mountiny]

We are not, @abzokhattab sorry, I marked this as internal as there might be some changes required in the backend, I will handle this one

[abzokhattab]

No problem, @mountiny go ahead

[mountiny]

PR is in review

[melvin-bot]

Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove the usage of isApprovalModeEnabled #38545

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

$250 to @hoangzinh for this this one

[mountiny]

No need for the checklist here

[slafortune]

Invite sent here @hoangzinh

[hoangzinh]

Accepted. Thanks @slafortune

[slafortune]

Paid