[HOLD for payment 2024-03-29] [Performance] Remove unused dependencies from the project and import only date-fns submodule

[mountiny]

Problem

Coming from Slack

Unused dependencies are increasing the bundle size which is making the app slower to start and its not a good practice in general.

Solution

Remove unused dependencies and for date-fns, only import the submodule we actually need.

Furthermore add an eslint to prevent the later from happening again

[melvin-bot]

Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[mountiny]

@jbroma please comment so I can assign you

[jbroma]

👋

[mountiny]

@kacper-mikolajczak can you comment here please?

[kacper-mikolajczak]

@mountiny commenting!

[mountiny]

PR merged

[mountiny]

I think this was straightforwards, no c+ to pay, we can close now

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] [Audit][Implementation] Bundle size: use submodule imports for date-fns/locale #38346
• [NoQA] [Audit][Implementation] Bundle size: remove unused dependencies #38344

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

• @kacper-mikolajczak does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@kacper-mikolajczak] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.