-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: There's a lot of extra space above the report actions #38449
Fix: There's a lot of extra space above the report actions #38449
Conversation
@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…above-the-report-actions
…above-the-report-actions
Updated |
also ccing @Expensify/design to review the changes |
@yuwenmemon Can we trigger an ad-hoc build, so the design changes can be reviewed easily? |
Hmm I think the background image should scroll with the content, so that at some point the background image just scrolls off the view entirely. |
… some point the background image just scrolls off the view entirely.
Also cc @Expensify/design to test this one out too (when things are stable...) |
#38449 (comment) is Fixed |
I'm having trouble to login on mobile device. Not sure if it's because of site issue. I'll continue testing when the site is full recovered. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
Confirming that the Safari mWeb bug seems to be gone, nice! Let's get this into final review and hopefully merge soon. |
I'm re-testing it |
Reviewer Checklist
Screenshots/VideosAndroid: Native0-android.mp4Android: mWeb Chrome0-mobile-chrome.mp4iOS: Native0-ios.mp4iOS: mWeb Safari0-mobile-safari.mp4MacOS: Chrome / Safari0-web.mp4MacOS: Desktop0-desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Love it, cc @allroundexperts @yuwenmemon - who needs to do the final review here? |
LGTM, just waiting on merge freeze to be lifted. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.77-0 🚀
|
I think it's possible that this PR also caused this regression #42795. Specifically the part where the background UI is overlapping the report |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
|
Details
Fixed Issues
$ #35921
$ #36166
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as above tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Recording.2024-03-17.201301.mp4
Android: mWeb Chrome
Recording.2024-03-17.184129.mp4
iOS: Native
Recording.2024-03-17.183354.mp4
iOS: mWeb Safari
Recording.2024-03-17.192448.mp4
MacOS: Chrome / Safari
Recording.2024-03-17.173321.mp4
MacOS: Desktop
Recording.2024-03-17.183920.mp4