[HOLD for payment 2024-04-03] [$500] [Simplified Collect][Taxes] - Unable to add custom tax name after clearing the custom tax name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.54-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an admin of Collect workspace

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces > Collect workspace
3. Go to More features
4. Toggle on Taxes
5. Click Add rate
6. Add a tax rate
7. Click Settings
8. Add a "Custom tax name", "Workspace currency default" and "Foreign currency default"
9. Click Custom tax name
10. Clear the custom name and save it
11. Click Custom tax name again
12. Add a custom tax name and save it

Expected Result:

The new custom tax name will be saved

Actual Result:

The new custom tax name is not saved and it reverts to empty state

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418096_1710781318657.20240319_005012.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017d9ced651589c65d
• Upwork Job ID: 1769782817172688896
• Last Price Increase: 2024-03-18
• Automatic offers:
• hungvu193 | Reviewer | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@arosiclair FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[luacmartins]

This is NAB since most people don't have access to this functionality yet. I can take this since it was introduced in #38373.

[luacmartins]

cc @kosmydel @filip-solecki

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017d9ced651589c65d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

We can fix this one as a follow up in the remaining taxes issues

[filip-solecki]

Hi! I am Filip from SWM and I'd like to work on it!

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[trjExpensify]

Automation didn't run. PR is on prod, needs payment tomorrow.

[trjExpensify]

Okay, so payment summary as follows:

• $500 to @hungvu193 for the C+ review

Offer sent

[hungvu193]

Okay, so payment summary as follows:

• $500 to @hungvu193 for the C+ review

Offer sent

I've just accepted the offer. Thank you

[trjExpensify]

Paid!