[$500] LHN - A pinned conversation will disappear from LHN when opened by another user

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.54-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4433236
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal team

Action Performed:

1. Open https://staging.new.expensify.com/
2. Log in to two new HT accounts that have no history of conversation with each other
3. From user A, open a conversation with user B and pin it to the LHN
4. Navigate to a conversation with the concierge
5. From user B, open a conversation with user A

Expected Result:

A pinned conversation should not disappear from the LHN when opened by another user

Actual Result:

pinned conversation will disappear from LHN when opened by another user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418228_1710788076282.Recording__1434.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014542ee688f9cf720
• Upwork Job ID: 1770145691913629696
• Last Price Increase: 2024-03-26

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014542ee688f9cf720

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

📣 @smart715! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[zanyrenney]

Just a note to say, I am OOO now until April 2nd, reassigning BZ team member to help while I am OOO.

[mallenexpensify]

Before diving in... @hoangzinh , do you think the bug might be occurring because the first half of the email is the same? (it doesn't make sense that it would, just happened to notice.

[hoangzinh]

@mallenexpensify I'm unsure. But I think it's a BE issue, where it resets/undo isPinned => leads to be hidden from LHN because there is no chat history

App/src/libs/ReportUtils.ts

Lines 4412 to 4415 in 4bc6744

	// Hide chats between two users that haven't been commented on from the LNH
	if (excludeEmptyChats && isEmptyChat && isChatReport(report) && !isChatRoom(report) && !isPolicyExpenseChat(report) && canHideReport) {
	return false;
	}

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

[mallenexpensify]

Thanks @hoangzinh , I made it Internal for now and also dropped in #expensify-open-source to get 👀 and feedback
https://expensify.slack.com/archives/C01GTK53T8Q/p1711497312675889

[zanyrenney]

@mallenexpensify didn't have any responses so i have bumped the thread.

[melvin-bot]

@hoangzinh, @mallenexpensify, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@hoangzinh, @mallenexpensify, @zanyrenney 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[mallenexpensify]

Added retest-weekly. I feel like, if this were a bug, people would encounter it more often and would have reported the past week or two.

[zanyrenney]

I've just tried to reproduce this again myself and I can't. I agree with Matt that it seems like people would have reported this more if it was a common issue. @mallenexpensify given my comment above, I'm curious what your thoughts are about closing this for now until we see it happening again?

[mallenexpensify]

@zanyrenney , I'll snag this from ya. I'm either going to close or add 'needs reproduction' and use as an example for how to manage bugs that need repro, which I'll be working on the coming weeks

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

Gonna close to avoid going down a 🐰🕳 to maybe find a way to repro. I'd rather close and have other comment/reopen then address the bug. That said... comment if you disagree.