[LOW] [Splits] [$500] Split - After clicking on a Split button for a member, WS disappears in the Recent list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.54-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Prerequisite: User has a WS

1. Tap FAB
2. Tap Request money
3. Tap Manual
4. Enter any value tap Next
5. Tap Split button on a Member row

Expected Result:

WS should still exist in the Recent list, after clicking on a Split button for a member

Actual Result:

WS disappear in the Recent list, after clicking on a Split button for a member

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418251_1710788778857.mobizen_20240318_220407.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013f16adcd9dc81d4a
• Upwork Job ID: 1772895473797611520
• Last Price Increase: 2024-03-27

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split - After clicking on a Split button for a member, WS disappears in the Recent list

What is the root cause of that problem?

Here we pass prop includeOwnedWorkspaceChats. When a participant is not selected, iouType is request, but after a participant is selected it becomes split and the iouType === CONST.IOU.TYPE.REQUEST condition becomes false.

What changes do you think we should make in order to solve the problem?

Always set the includeOwnedWorkspaceChats property to true or update the condition like below

iouType === CONST.IOU.TYPE.REQUEST || iouType === CONST.IOU.TYPE.SPLIT

What alternative solutions did you explore? (Optional)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We use getFilteredOptions function to get the list of people and policies.
In here by default, we set includeOwnedWorkspaceChats to false:

App/src/libs/OptionsListUtils.ts

Lines 1811 to 1818 in 22bd9eb

	function getFilteredOptions(
	reports: OnyxCollection<Report>,
	personalDetails: OnyxEntry<PersonalDetailsList>,
	betas: OnyxEntry<Beta[]> = [],
	searchValue = '',
	selectedOptions: Array<Partial<ReportUtils.OptionData>> = [],
	excludeLogins: string[] = [],
	includeOwnedWorkspaceChats = false,

and in participant selector page, We only display both owned policies and people when the IOU type is request:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 123 in 7946b15

iouType === CONST.IOU.TYPE.REQUEST,

This fails when we have selected one participant as now, it will become a split request

What changes do you think we should make in order to solve the problem?

We should update the condition in MoneyTemporaryForRefactorRequestParticipantsSelector such that it will be true when iouType exits, this will cover the case where the request is a scan type:

        const chatOptions = OptionsListUtils.getFilteredOptions(
            reports,
            personalDetails,
            betas,
            searchTerm,
            participants,
            CONST.EXPENSIFY_EMAILS,

            // If we are using this component in the "Request money" flow then we pass the includeOwnedWorkspaceChats argument so that the current user
            // sees the option to request money from their admin on their own Workspace Chat.
-            iouType === CONST.IOU.TYPE.REQUEST,
+            !!iouType,
            // OR we can check if the type is not equal to `send`
+           iouType !== CONST.IOU.TYPE.SEND

What alternative solutions did you explore? (Optional)

N/A

[miljakljajic]

this should be fine to be handled externally @lanitochka17 - adding the label now!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013f16adcd9dc81d4a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[FitseTLT]

@miljakljajic This expected behaviour we can not split between workspace and users

[miljakljajic]

That makes sense thank you, closing!